r114171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114170‎ | r114171 | r114172 >
Date:19:05, 19 March 2012
Author:wikinaut
Status:new
Tags:
Comment:
removed the redundant code for handling tracking categories. By using '-' for the message text etherpadlite-tracking-category , this can be disabled easily.
Modified paths:
  • /trunk/extensions/EtherpadLite/EtherpadLite.php (modified) (history)
  • /trunk/extensions/EtherpadLite/EtherpadLite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EtherpadLite/EtherpadLite.php
@@ -64,7 +64,7 @@
6565 'path' => __FILE__,
6666 'name' => 'EtherpadLite',
6767 'author' => array( 'Thomas Gries' ),
68 - 'version' => '1.12 20120309',
 68+ 'version' => '1.13 20120319',
6969 'url' => 'https://www.mediawiki.org/wiki/Extension:EtherpadLite',
7070 'descriptionmsg' => 'etherpadlite-desc',
7171 );
@@ -104,20 +104,3 @@
105105
106106 # include "*" if you expressly want to allow all urls (you should not do this)
107107 # $wgEtherpadLiteUrlWhitelist = array( "*" );
108 -
109 -// If you want to see images in feed items, then you need to globally allow
110 -// image tags in your wiki by using the MediaWiki parameter; default: false
111 -// $wgAllowImageTag = true;
112 -
113 -// Parameter to enable the automatic tracking category
114 -// for all pages using this parser extension
115 -//
116 -// Category name [[MediaWiki:etherpadlite-tracking-category]] (default)
117 -// $wgEtherpadLiteTrackingCategory = true;
118 -//
119 -// you can assign a specific category name [[MediaWiki:Etherpadlite-mycategory]]
120 -// $wgEtherpadLiteTrackingCategory = 'etherpadlite-mycategory';
121 -//
122 -// you can disable the use of a tracking category
123 -// $wgEtherpadLiteTrackingCategory = false;
124 -$wgEtherpadLiteTrackingCategory = true;
Index: trunk/extensions/EtherpadLite/EtherpadLite_body.php
@@ -39,7 +39,7 @@
4040 global $wgEtherpadLiteDefaultPadUrl, $wgEtherpadLiteDefaultWidth, $wgEtherpadLiteDefaultHeight,
4141 $wgEtherpadLiteMonospacedFont, $wgEtherpadLiteShowControls, $wgEtherpadLiteShowLineNumbers,
4242 $wgEtherpadLiteShowChat, $wgEtherpadLiteShowAuthorColors, $wgEtherpadLiteUrlWhitelist,
43 - $wgEtherpadLitePadsOnThisPage, $wgEtherpadLiteTrackingCategory;
 43+ $wgEtherpadLitePadsOnThisPage;
4444
4545 # check the user input
4646
@@ -166,16 +166,8 @@
167167 $sanitizedAttributes
168168 );
169169
170 - wfDebug( "EtherpadLite::EtherpadLiteRender $output\n" );
171 -
172 - if ( $wgEtherpadLiteTrackingCategory === true ) {
173 - $parser->addTrackingCategory( 'etherpadlite-tracking-category' );
174 - } elseif ( is_string( $wgEtherpadLiteTrackingCategory ) ) {
175 - $parser->addTrackingCategory( $wgEtherpadLiteTrackingCategory );
176 - }
177 -
 170+ $parser->addTrackingCategory( 'etherpadlite-tracking-category' );
178171 return $output;
179 -
180172 }
181173
182174 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113516add tracking category feature (enabled by default). Each page using this exte...wikinaut20:01, 9 March 2012

Status & tagging log