r114122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114121‎ | r114122 | r114123 >
Date:02:30, 19 March 2012
Author:zaran
Status:reverted
Tags:gerritmigration 
Comment:
Follow-up to r114004 - Use tabs instead of spaces
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread.js
@@ -754,10 +754,10 @@
755755 pr_make_edit_area( self.text_container, text.value );
756756 f.insertBefore( table, text.nextSibling ); // Inserts table after text
757757 f.removeChild( text );
758 - if ( mw.user.options.get( 'proofreadpage-showheaders' ) ) {
759 - hookEvent( 'load', pr_reset_size );
 758+ if ( mw.user.options.get( 'proofreadpage-showheaders' ) ) {
 759+ hookEvent( 'load', pr_reset_size );
760760 } else {
761 - hookEvent( 'load', pr_toggle_visibility );
 761+ hookEvent( 'load', pr_toggle_visibility );
762762 }
763763 } else {
764764 var new_text = f.removeChild( text );

Sign-offs

UserFlagDate
Nikerabbitinspected09:34, 19 March 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r114398Revert r113358, r113461, r114004, r114122. Unreviewed revs in ProofreadPage....catrope19:44, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114004Bug 34942 - Add a show Headers preference. Apply ThomasPT's patchzaran09:08, 16 March 2012

Status & tagging log