r114003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114002‎ | r114003 | r114004 >
Date:07:24, 16 March 2012
Author:santhosh
Status:ok
Tags:i18nreview 
Comment:
Handle an edge case where $priorityreason is "0" and evaluates to false making it not moved to new page metadata.
Ping r113225
Modified paths:
  • /trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php
@@ -421,7 +421,7 @@
422422 if ( $priorityforce ) {
423423 TranslateMetadata::set( $newGroupId, 'priorityforce', $priorityforce );
424424 }
425 - if ( $priorityreason ) {
 425+ if ( $priorityreason !== false ) {
426426 TranslateMetadata::set( $newGroupId, 'priorityreason', $priorityreason );
427427 }
428428 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113225Clear the associated metadata when a translatable page is deleted....santhosh11:45, 7 March 2012

Status & tagging log