r113992 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113991‎ | r113992 | r113993 >
Date:01:44, 16 March 2012
Author:christian
Status:deferred
Tags:
Comment:
fixes to ie ce test demo
Modified paths:
  • /trunk/extensions/VisualEditor/demos/playground/flip.html (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/demos/playground/flip.html
@@ -25,10 +25,14 @@
2626 $('#editor').attr('contenteditable', true);
2727 })
2828 .focus(function() {
29 - console.log('thumbnail has focus. this probably shouldn't happen.');
 29+ console.log('thumbnail has focus. this probably should not happen.');
3030 });
3131 $('#editor').click(function() {
32 - if ($(rangy.getSelection().anchorNode).closest('[contenteditable="false"]').length) {
 32+ var node = rangy.getSelection().anchorNode;
 33+ while (node.nodeType === 3) {
 34+ node = node.parentNode;
 35+ }
 36+ if (!node.isContentEditable) {
3337 console.log('cursor is in the wrong place. fix it!');
3438 }
3539 });
@@ -36,6 +40,7 @@
3741 </script>
3842 <style>
3943 [contenteditable="true"] {
 44+ cursor: text;
4045 outline: 0;
4146 }
4247 #editor {
@@ -101,15 +106,7 @@
102107 THUMB
103108 <p contenteditable="true">this is the caption</p>
104109 </div>
105 -
106 - <p>This week, I was seeing a drop in average back-end performance at work, we had an average drop in page load performance from ~250ms to around 500ms. This seemed to be an intermittent problem and we searched through out graphs at NewRelic with no clear culprit.</p>
107110
108 - <p>I’ve worked at several environments where most of our product was run through the JVM. I’ve always used the information available to me in Mbeans, but the overhead of exposing them to a monitoring system like Ganglia or Nagios has always been problematic.</p>
109 -
110 - <p>This week, I was seeing a drop in average back-end performance at work, we had an average drop in page load performance from ~250ms to around 500ms. This seemed to be an intermittent problem and we searched through out graphs at NewRelic with no clear culprit.</p>
111 -
112 - <p>I’ve worked at several environments where most of our product was run through the JVM. I’ve always used the information available to me in Mbeans, but the overhead of exposing them to a monitoring system like Ganglia or Nagios has always been problematic.</p>
113 -
114111 </div>
115112 </body>
116113 </html>
\ No newline at end of file

Status & tagging log