r113976 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113975‎ | r113976 | r113977 >
Date:23:25, 15 March 2012
Author:catrope
Status:ok
Tags:
Comment:
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -216,7 +216,7 @@
217217 'ratings': mw.config.get( 'wgArticleFeedbackRatingTypesFlipped' ),
218218 'pitches': {
219219 'survey': {
220 - 'weight': 1,
 220+ 'weight': 0,
221221 'condition': function() {
222222 return isPitchVisible( 'survey' );
223223 },
@@ -234,7 +234,7 @@
235235 'reject': 'articlefeedback-pitch-reject'
236236 },
237237 'join': {
238 - 'weight': 1,
 238+ 'weight': 0,
239239 'condition': function() {
240240 return isPitchVisible( 'join' ) && mw.user.anonymous();
241241 },
@@ -272,7 +272,7 @@
273273 }
274274 },
275275 'edit': {
276 - 'weight': 2,
 276+ 'weight': 1,
277277 'condition': function() {
278278 // An empty restrictions array means anyone can edit
279279 var restrictions = mw.config.get( 'wgRestrictionEdit', [] );
@@ -334,7 +334,8 @@
335335 .text( mw.msg( 'articlefeedback-form-switch-label' ) )
336336 .click( function() {
337337 // Click tracking
338 - trackClick( 'toolbox-link' );
 338+ // Temporarily disabled per Dario's request --Roan
 339+ //trackClick( 'toolbox-link' );
339340 // Get the image, set the count and an interval.
340341 var $box = $( '#mw-articlefeedback' );
341342 var count = 0;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r1139581.19wmf1: Adjust pitch weights in AFTv4 per Dario's request. Will merge back ...catrope21:11, 15 March 2012
r1139591.19wmf1: Temporarily disable clicktracking for toolbox-link per Dario. Will ...catrope21:18, 15 March 2012

Status & tagging log