r113970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113969‎ | r113970 | r113971 >
Date:23:03, 15 March 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Drop jquery.elastic and allow regular browser scrolling/resizing:
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css:
- Allow the textarea to scroll and, if the browser permits it, resize
manually
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- Dropped jquery.elastic
- Allow the overlay to be resized as well, in case someone has a truly
enormous comment
- modules/jquery.elastic:
- Deleted
- ArticleFeedbackv5.hooks.php:
- Dropped jquery.elastic
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.elastic (deleted) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -608,12 +608,10 @@
609609 }
610610
611611 .articleFeedbackv5-ui .feedback-text {
612 - resize: none;
613612 background: #fff;
614613 border: 1px solid #000;
615614 width: 518px;
616615 height: 42px;
617 - overflow: hidden;
618616 padding: 10px;
619617 font-size: 1.1em;
620618 font-family: sans-serif !important;
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -200,7 +200,7 @@
201201 ',
202202
203203 clear: '<div class="clear"></div>'
204 -
 204+
205205 };
206206
207207 // }}}
@@ -2177,7 +2177,7 @@
21782178 // Track init at 1%
21792179 if ( Math.random() * 100 < 1 ) {
21802180 $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-init' );
2181 - }
 2181+ }
21822182 };
21832183
21842184 // }}}
@@ -2565,7 +2565,7 @@
25662566 width: 500,
25672567 height: 300,
25682568 dialogClass: 'articleFeedbackv5-dialog',
2569 - resizable: false,
 2569+ resizable: true,
25702570 draggable: true,
25712571 title: $.articleFeedbackv5.currentBucket().getTitle(),
25722572 modal: true,
@@ -2625,9 +2625,6 @@
26262626 // Set the tooltip link
26272627 $.articleFeedbackv5.find( '.articleFeedbackv5-tooltip-link' )
26282628 .attr( 'href', mw.msg( 'articlefeedbackv5-help-tooltip-linkurl' ));
2629 -
2630 - // Have the feedback textarea grow automatically
2631 - $.articleFeedbackv5.find( '#articleFeedbackv5-find-feedback' ).elastic();
26322629
26332630 // Do anything special the bucket requires
26342631 if ( 'afterBuild' in bucket ) {
@@ -2673,7 +2670,7 @@
26742671
26752672 // Lock the form
26762673 $.articleFeedbackv5.lockForm();
2677 -
 2674+
26782675 // this is a good time to hide the help box, if its displayed
26792676 $( '.articleFeedbackv5-tooltip' ).hide();
26802677
@@ -3173,8 +3170,8 @@
31743171 };
31753172
31763173 // }}}
 3174+ // {{{ trackActionURL
31773175
3178 - // {{{ trackClick
31793176 /**
31803177 * Rewrites a URL to one that runs through the ClickTracking API module
31813178 * which registers the event and redirects to the real URL
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -164,7 +164,6 @@
165165 'jquery.ui.button',
166166 'jquery.cookie',
167167 'jquery.clickTracking',
168 - 'jquery.articleFeedbackv5.elastic',
169168 ),
170169 ),
171170 'jquery.articleFeedbackv5.special' => array(
@@ -189,7 +188,7 @@
190189 'articlefeedbackv5-comment-more',
191190 'articlefeedbackv5-comment-less',
192191 'articlefeedbackv5-error-loading-feedback',
193 -
 192+
194193 'articlefeedbackv5-noteflyover-hide-caption',
195194 'articlefeedbackv5-noteflyover-hide-label',
196195 'articlefeedbackv5-noteflyover-hide-placeholder',
@@ -238,7 +237,7 @@
239238 'articlefeedbackv5-noteflyover-declineoversight-submit',
240239 'articlefeedbackv5-noteflyover-declineoversight-help',
241240 'articlefeedbackv5-noteflyover-declineoversight-help-link',
242 -
 241+
243242 'articlefeedbackv5-mask-text-hidden',
244243 'articlefeedbackv5-mask-text-oversight',
245244 'articlefeedbackv5-mask-postnumber'
@@ -248,10 +247,6 @@
249248 'jquery.tipsy'
250249 ),
251250 ),
252 - // TODO: Move jquery.elastic into core resources
253 - 'jquery.articleFeedbackv5.elastic' => array(
254 - 'scripts' => 'jquery.elastic/jquery.elastic.js'
255 - ),
256251 );
257252
258253 /* Static Methods */

Status & tagging log