r113941 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113940‎ | r113941 | r113942 >
Date:17:52, 15 March 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
remove rights admins should not have and added some message docs
Modified paths:
  • /trunk/extensions/EducationProgram/EducationProgram.i18n.php (modified) (history)
  • /trunk/extensions/EducationProgram/EducationProgram.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/EducationProgram.php
@@ -285,10 +285,8 @@
286286 $wgGroupPermissions['epadmin']['ep-token'] = true;
287287 $wgGroupPermissions['epadmin']['ep-enroll'] = true;
288288 $wgGroupPermissions['epadmin']['ep-remstudent'] = true;
289 -$wgGroupPermissions['epadmin']['ep-online'] = true;
290289 $wgGroupPermissions['epadmin']['ep-campus'] = true;
291290 $wgGroupPermissions['epadmin']['ep-instructor'] = true;
292 -$wgGroupPermissions['epadmin']['ep-beonline'] = true;
293291 $wgGroupPermissions['epadmin']['ep-becampus'] = true;
294292 $wgGroupPermissions['epadmin']['ep-beinstructor'] = true;
295293 $wgGroupPermissions['epadmin']['ep-bereviewer'] = true;
Index: trunk/extensions/EducationProgram/EducationProgram.i18n.php
@@ -142,7 +142,7 @@
143143 'right-ep-instructor' => 'Add or remove instructors to courses',
144144 'right-ep-beonline' => 'Add or remove yourself as online ambassador from terms',
145145 'right-ep-becampus' => 'Add or remove yourself as campus ambassador from terms',
146 - 'right-ep-beinstructor' => ' Add or remove yourself as instructor from courses',
 146+ 'right-ep-beinstructor' => 'Add or remove yourself as instructor from courses',
147147 'right-ep-bereviewer' => 'Add or remove yourself as reviewer from articles',
148148 'right-ep-remreviewer' => 'Remove reviewers from articles',
149149 'right-ep-bulkdelorgs' => 'Bulk delete institutions',
@@ -772,21 +772,60 @@
773773
774774 /** Message documentation (Message documentation)
775775 * @author Jeroen De Dauw
 776+ *
 777+ * Please leave the doc headers intact, else it becomes very hard to
 778+ * get a decent overview of what is and what is not (yet) documented!
776779 */
777780 $messages['qqq'] = array(
778 - 'right-' => '{{doc-right|}}',
 781+ // Rights
 782+ 'right-ep-org' => '{{doc-right|ep-org}}',
 783+ 'right-ep-course' => '{{doc-right|ep-course}}',
 784+ 'right-ep-token' => '{{doc-right|ep-token}}',
 785+ 'right-ep-remstudent' => '{{doc-right|ep-remstudent}}',
 786+ 'right-ep-enroll' => '{{doc-right|ep-enroll}}',
 787+ 'right-ep-online' => '{{doc-right|ep-online}}',
 788+ 'right-ep-campus' => '{{doc-right|ep-campus}}',
 789+ 'right-ep-instructor' => '{{doc-right|ep-instructor}}',
 790+ 'right-ep-beonline' => '{{doc-right|ep-beonline}}',
 791+ 'right-ep-becampus' => '{{doc-right|ep-becampus}}',
 792+ 'right-ep-beinstructor' => '{{doc-right|ep-beinstructor}}',
 793+ 'right-ep-bereviewer' => '{{doc-right|ep-bereviewer}}',
 794+ 'right-ep-remreviewer' => '{{doc-right|ep-remreviewer}}',
 795+ 'right-ep-bulkdelorgs' => '{{doc-right|ep-bulkdelorgs}}',
 796+ 'right-ep-bulkdelcourses' => '{{doc-right|ep-bulkdelcourses}}',
779797
780 - 'action-' => '{{doc-action|}}',
 798+ // Actions
 799+ 'action-ep-org' => '{{doc-action|ep-org}}',
 800+ 'action-ep-course' => '{{doc-action|ep-course}}',
 801+ 'action-ep-token' => '{{doc-action|ep-token}}',
 802+ 'action-ep-remstudent' => '{{doc-action|ep-remstudent}}',
 803+ 'action-ep-enroll' => '{{doc-action|ep-enroll}}',
 804+ 'action-ep-online' => '{{doc-action|ep-online}}',
 805+ 'action-ep-campus' => '{{doc-action|ep-campus}}',
 806+ 'action-ep-instructor' => '{{doc-action|ep-instructor}}',
 807+ 'action-ep-beonline' => '{{doc-action|ep-beonline}}',
 808+ 'action-ep-becampus' => '{{doc-action|ep-becampus}}',
 809+ 'action-ep-beinstructor' => '{{doc-action|ep-beinstructor}}',
 810+ 'action-ep-bereviewer' => '{{doc-action|ep-bereviewer}}',
 811+ 'action-ep-remreviewer' => '{{doc-action|ep-remreviewer}}',
 812+ 'action-ep-bulkdelorgs' => '{{doc-action|ep-bulkdelorgs}}',
 813+ 'action-ep-bulkdelcourses' => '{{doc-action|ep-bulkdelcourses}}',
781814
 815+ // Special pages
782816 'specialpages-group-education' => 'Special pages group, h2',
783817 'special-mycourses' => '{{doc-special|mycourses}}',
784 - 'special-institution' => '{{doc-special|institution}}',
785818 'special-institutions' => '{{doc-special|institutions}}',
786819 'special-student' => '{{doc-special|student}}',
787820 'special-students' => '{{doc-special|students}}',
788 - 'special-course' => '{{doc-special|course}}',
789821 'special-courses' => '{{doc-special|courses}}',
790822 'special-educationprogram' => '{{doc-special|educationprogram}}',
 823+ 'special-enroll' => '{{doc-special|enroll}}',
 824+ 'special-onlineambassadors' => '{{doc-special|onlineambassadors}}',
 825+ 'special-campusambassadors' => '{{doc-special|campusambassadors}}',
 826+ 'special-onlineambassador' => '{{doc-special|onlineambassador}}',
 827+ 'special-campusambassador' => '{{doc-special|campusambassador}}',
 828+ 'special-disenroll' => '{{doc-special|disenroll}}',
791829
792 - 'ep-institutions-nosuchinstitution' => 'Error message stating there is no institution with name $1',
 830+
 831+
793832 );

Status & tagging log