r113873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113872‎ | r113873 | r113874 >
Date:22:59, 14 March 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
tweaks suggested by beta testers
Modified paths:
  • /trunk/extensions/EducationProgram/EducationProgram.i18n.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/includes/EPUtils.php
@@ -169,7 +169,7 @@
170170 $attribs = array();
171171 }
172172
173 - $links[] = Linker::linkKnown(
 173+ $links[] = Linker::link(
174174 $target,
175175 htmlspecialchars( $label ),
176176 $attribs
@@ -188,7 +188,7 @@
189189 *
190190 * @param IContextSource $context
191191 *
192 - * @return array
 192+ * @return array of Title
193193 */
194194 public static function getDefaultNavigationItems( IContextSource $context ) {
195195 $items = array(
Index: trunk/extensions/EducationProgram/EducationProgram.i18n.php
@@ -208,12 +208,12 @@
209209
210210 // Special:EducationProgram
211211 'ep-summary-table-header' => 'Education Program summary',
212 - 'specialeducationprogram-summary-org-count' => 'Amount of [[Special:Institutions|institutions]]',
213 - 'specialeducationprogram-summary-course-count' => 'Amount of [[Special:Courses|courses]]',
214 - 'specialeducationprogram-summary-student-count' => 'Amount of [[Special:Students|students]]',
215 - 'specialeducationprogram-summary-instructor-count' => 'Amount of instructors',
216 - 'specialeducationprogram-summary-ca-count' => 'Amount of [[Special:CampusAmbassadors|Campus Ambassadors]]',
217 - 'specialeducationprogram-summary-oa-count' => 'Amount of [[Special:OnlineAmbassadors|Online Ambassadors]]',
 212+ 'specialeducationprogram-summary-org-count' => 'Number of [[Special:Institutions|institutions]]',
 213+ 'specialeducationprogram-summary-course-count' => 'Number of [[Special:Courses|courses]]',
 214+ 'specialeducationprogram-summary-student-count' => 'Number of [[Special:Students|students]]',
 215+ 'specialeducationprogram-summary-instructor-count' => 'Number of instructors',
 216+ 'specialeducationprogram-summary-ca-count' => 'Number of [[Special:CampusAmbassadors|Campus Ambassadors]]',
 217+ 'specialeducationprogram-summary-oa-count' => 'Number of [[Special:OnlineAmbassadors|Online Ambassadors]]',
218218
219219 // Special:Institutions
220220 'ep-institutions-nosuchinstitution' => 'There is no institution with name "$1". Existing institutions are listed below.',

Status & tagging log