r113845 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113844‎ | r113845 | r113846 >
Date:20:52, 14 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix message key typo

Couple of TODO comments
Modified paths:
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor.i18n.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributorSVN.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -238,7 +238,7 @@
239239 // Determine tar name.
240240 $cleanName = str_replace( '/', '_', $extension );
241241 $versionName = $wgExtDistBranches[$version]['tarLabel'];
242 - $tarName = "$cleanName-$versionName-r$rev.tar.gz";
 242+ $tarName = "$cleanName-$versionName-r$rev.tar.gz"; // TODO: Do we still want r prefix for git? Probably not
243243 $tarFile = "$wgExtDistTarDir/$tarName";
244244
245245 // Create the archive if it doesn't exist.
@@ -293,12 +293,11 @@
294294 protected function updateAndGetRevisionLocal( $extension, $version, $vcs ) {
295295 global $wgExtDistWorkingCopy, $wgOut;
296296
297 - // svn up
298297 $dir = "$wgExtDistWorkingCopy/$version/extensions/$extension";
299298
300299 $ed = ExtensionDistributorVCS::factory( $vcs );
301300 if ( $ed === null ) {
302 - $wgOut->addWikiMsg( 'extdist-cvs-unsupported', $vcs );
 301+ $wgOut->addWikiMsg( 'extdist-vcs-unsupported', $vcs );
303302 return false;
304303 }
305304
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor.i18n.php
@@ -48,7 +48,7 @@
4949
5050 If you have any questions about this extension distribution system, please go to [[Extension talk:ExtensionDistributor]].",
5151 'extdist-want-more' => 'Get another extension',
52 - 'extdist-cvs-unsupported' => 'Extension Distributor doesn\'t support the "$1" version control system.',
 52+ 'extdist-vcs-unsupported' => 'Extension Distributor doesn\'t support the "$1" version control system.',
5353 'extdist-git-invalid-dir' => 'Unable to enter directory for git checkout',
5454 );
5555
@@ -593,7 +593,7 @@
594594
595595 Sofern du Fragen und Anmerkungen zu diesem System zur Verteilung von Erweiterungen hast, nutze bitte diese [[Extension talk:ExtensionDistributor|Diskussionsseite]].",
596596 'extdist-want-more' => 'Eine weitere Erweiterung herunterladen',
597 - 'extdist-cvs-unsupported' => 'Das Versionsverwaltungssystem „$1“ wird nicht unterstützt.',
 597+ 'extdist-vcs-unsupported' => 'Das Versionsverwaltungssystem „$1“ wird nicht unterstützt.',
598598 'extdist-git-invalid-dir' => 'Auf das Verzeichnis zum Abruf über Git konnte nicht zugegriffen werden.',
599599 );
600600
@@ -890,7 +890,7 @@
891891
892892 Si tienes cualquier duda sobre este sistema de distribución de extensiones, por favor ve a [[Extension talk:ExtensionDistributor]].",
893893 'extdist-want-more' => 'Obtener otra extensión',
894 - 'extdist-cvs-unsupported' => 'El Distribuidor de extensión no admite el sistema de control de versión "$1".',
 894+ 'extdist-vcs-unsupported' => 'El Distribuidor de extensión no admite el sistema de control de versión "$1".',
895895 'extdist-git-invalid-dir' => 'No se ha podido entrar al directorio para la comprobación de Git',
896896 );
897897
@@ -1088,7 +1088,7 @@
10891089
10901090 Si vous avez des questions concernant ce système de distribution des extensions, veuillez consulter [[Extension talk:ExtensionDistributor]].",
10911091 'extdist-want-more' => 'Obtenir une autre extension',
1092 - 'extdist-cvs-unsupported' => 'Le distributeur d\'extension ne supporte pas le système de contrôle de version "$1".',
 1092+ 'extdist-vcs-unsupported' => 'Le distributeur d\'extension ne supporte pas le système de contrôle de version "$1".',
10931093 'extdist-git-invalid-dir' => "Impossible d'entrer dans le répertoire pour une inspection de Git",
10941094 );
10951095
@@ -1197,7 +1197,7 @@
11981198
11991199 Se ten algunha dúbida ou pregunta acerca do sistema de distribución das extensións, por favor, vaia a [[Extension talk:ExtensionDistributor]].",
12001200 'extdist-want-more' => 'Obter outra extensión',
1201 - 'extdist-cvs-unsupported' => 'A extensión de distribución non soporta o sistema de control de versións "$1".',
 1201+ 'extdist-vcs-unsupported' => 'A extensión de distribución non soporta o sistema de control de versións "$1".',
12021202 'extdist-git-invalid-dir' => 'Non se pode entrar no directorio para a comprobación do Git',
12031203 );
12041204
@@ -1433,7 +1433,7 @@
14341434
14351435 Jeli maš prašenja wo systemje rozdźělowanja rozšěrjenjow, prošu dźi k [[Extension talk:ExtensionDistributor]].",
14361436 'extdist-want-more' => 'Dalše rozšěrjenje wobstarać',
1437 - 'extdist-cvs-unsupported' => 'Extension Distributor wersijowy kontrolny system "$1" njepodpěruje.',
 1437+ 'extdist-vcs-unsupported' => 'Extension Distributor wersijowy kontrolny system "$1" njepodpěruje.',
14381438 'extdist-git-invalid-dir' => 'Njeje móžno, zapis za wotwołanje přez Git zapodać',
14391439 );
14401440
@@ -1539,7 +1539,7 @@
15401540
15411541 Si tu ha questiones super iste systema de distribution de extensiones, per favor visita [[Extension talk:ExtensionDistributor]].",
15421542 'extdist-want-more' => 'Obtener un altere extension',
1543 - 'extdist-cvs-unsupported' => 'Extension Distributor non supporta le systema de controlo de versiones "$1".',
 1543+ 'extdist-vcs-unsupported' => 'Extension Distributor non supporta le systema de controlo de versiones "$1".',
15441544 'extdist-git-invalid-dir' => 'Impossibile entrar in le directorio pro le synchronisation sortiente (checkout) ab Git',
15451545 );
15461546
@@ -1969,7 +1969,7 @@
19701970
19711971 Доколку имате прашања за овој дистрибутивен систем на додатоци, обратете се на страницата [[Extension talk:ExtensionDistributor]].",
19721972 'extdist-want-more' => 'Преземи друг додаток',
1973 - 'extdist-cvs-unsupported' => 'Распространувачот на додатоци не ја поддржува контролниот систем на верзии „$1“.',
 1973+ 'extdist-vcs-unsupported' => 'Распространувачот на додатоци не ја поддржува контролниот систем на верзии „$1“.',
19741974 'extdist-git-invalid-dir' => 'Не можам да навлезам во директориумот за проверка на Git',
19751975 );
19761976
@@ -2236,7 +2236,7 @@
22372237
22382238 Als u vragen hebt over dit distributiesysteem voor uitbreidingen, ga dan naar [[Extension talk:ExtensionDistributor]].',
22392239 'extdist-want-more' => 'Nog een uitbreiding downloaden',
2240 - 'extdist-cvs-unsupported' => 'Het is niet mogelijk om uitbreidingen te distribueren met behulp van het versioncontrolsysteem "$1" omdat dit niet wordt ondersteund.',
 2240+ 'extdist-vcs-unsupported' => 'Het is niet mogelijk om uitbreidingen te distribueren met behulp van het versioncontrolsysteem "$1" omdat dit niet wordt ondersteund.',
22412241 'extdist-git-invalid-dir' => 'Het was niet mogelijk om de map te gebruiken voor "git checkout"',
22422242 );
22432243
@@ -2420,7 +2420,7 @@
24212421
24222422 Jeśli masz jakieś pytania na temat systemu dystrybuującego rozszerzenia, zadaj je na stronie [[Extension talk:ExtensionDistributor]].",
24232423 'extdist-want-more' => 'Pobierz inne rozszerzenie',
2424 - 'extdist-cvs-unsupported' => 'Dystrybutor rozszerzenia nie obsługuje systemu kontroli wersji "$1".',
 2424+ 'extdist-vcs-unsupported' => 'Dystrybutor rozszerzenia nie obsługuje systemu kontroli wersji "$1".',
24252425 'extdist-git-invalid-dir' => 'Nie można wprowadzić katalogu git do pobrania',
24262426 );
24272427
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributorSVN.php
@@ -9,7 +9,6 @@
1010 public function updateAndGetVersion( $dir ) {
1111 $cmd = "svn up --non-interactive " . wfEscapeShellArg( $dir ) . " 2>&1";
1212 $retval = -1;
13 -
1413 $result = wfShellExec( $cmd, $retval );
1514
1615 if ( $retval ) {

Status & tagging log