r113755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113754‎ | r113755 | r113756 >
Date:20:09, 13 March 2012
Author:aaron
Status:ok
Tags:
Comment:
Reverted r113177 per CR
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -480,11 +480,6 @@
481481 return null;
482482 }
483483
484 - if ( User::isIP( $name ) ) {
485 - # Cannot exist
486 - return null;
487 - }
488 -
489484 if ( isset( self::$idCacheByName[$name] ) ) {
490485 return self::$idCacheByName[$name];
491486 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113177No need to do a database query when passing an IP address to User::idFromName()ialex20:52, 6 March 2012

Status & tagging log