r113693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113692‎ | r113693 | r113694 >
Date:00:21, 13 March 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
remove unrecognised max-width property

turns out this doesn't actually do anything.
would help if there was good documentation on viewport
viewport by default takes up max width possible
Modified paths:
  • /trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php
@@ -54,7 +54,7 @@
5555 <link href='{$this->data['wgExtensionAssetsPath']}/MobileFrontend/stylesheets/{$betaPrefix}common.css?version=1331257310' media='all' rel='Stylesheet' type='text/css' />
5656 <link href='{$this->data['wgExtensionAssetsPath']}/MobileFrontend/stylesheets/{$cssFileName}.css?version=1331257310' media='all' rel='Stylesheet' type='text/css' />
5757 {$filePageStyle}
58 - <meta name="viewport" content="max-width=device-width, initial-scale=1.0">
 58+ <meta name="viewport" content="initial-scale=1.0">
5959 {$appleTouchIconTag}
6060 {$jQueryScript}
6161 <script type='text/javascript'>

Follow-up revisions

RevisionCommit summaryAuthorDate
r114201MFT r113486, r113488, r113512, r113553, r113640, r113642, r113644, r113645, r...awjrichards22:18, 19 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113463use max-width for viewport not width...jdlrobson11:03, 9 March 2012

Status & tagging log