r113683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113682‎ | r113683 | r113684 >
Date:23:11, 12 March 2012
Author:brion
Status:ok
Tags:
Comment:
Drop check for commented-out wgUploadWizardDisableResourceLoader var, UW no longer works without RL
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.php
@@ -62,9 +62,6 @@
6363
6464 $wgAPIModules['deleteuploadcampaign'] = 'ApiDeleteUploadCampaign';
6565
66 -// Disable ResourceLoader support by default, it's currently broken
67 -// $wgUploadWizardDisableResourceLoader = true;
68 -
6966 // for ResourceLoader
7067 $wgHooks['ResourceLoaderRegisterModules'][] = 'UploadWizardHooks::resourceLoaderRegisterModules';
7168 $wgHooks['CanonicalNamespaces'][] = 'UploadWizardHooks::canonicalNamespaces';
Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -425,10 +425,7 @@
426426 * Adds modules to ResourceLoader
427427 */
428428 public static function resourceLoaderRegisterModules( &$resourceLoader ) {
429 - global $wgExtensionAssetsPath, $wgUploadWizardDisableResourceLoader;
430 - if ( $wgUploadWizardDisableResourceLoader ) {
431 - return true;
432 - }
 429+ global $wgExtensionAssetsPath;
433430
434431 $localpath = dirname( __FILE__ );
435432 $remotepath = "$wgExtensionAssetsPath/UploadWizard";

Status & tagging log