r113646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113645‎ | r113646 | r113647 >
Date:18:26, 12 March 2012
Author:wikinaut
Status:new
Tags:
Comment:
The unique poll-id (hash) is now invisibly with color=background-color placed into the lower right corner of the poll div. This allows admins an easier maintainance of polls, if this is needed.
Modified paths:
  • /trunk/extensions/AJAXPoll/AJAXPoll.css (modified) (history)
  • /trunk/extensions/AJAXPoll/AJAXPoll.php (modified) (history)
  • /trunk/extensions/AJAXPoll/AJAXPoll_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AJAXPoll/AJAXPoll_body.php
@@ -297,10 +297,8 @@
298298 </script>
299299 <div class="ajaxpoll-question">' . strip_tags( $lines[0] ) . '</div>';
300300
301 - // Different message depending on if the user has already voted or not.
 301+ // Different message depending on if the user has already voted or not, or is entitled to vote
302302
303 - // $message = ( isset( $row[0] ) ) ? $ourLastVoteDate : wfMsg( 'ajaxpoll-no-vote' );
304 -
305303 if ( $wgUser->isAllowed( 'ajaxpoll-vote' ) ) {
306304 $message = ( isset( $row[0] ) ) ? $ourLastVoteDate : wfMsg( 'ajaxpoll-no-vote' );
307305 } else {
@@ -367,9 +365,7 @@
368366 $wgLang->timeanddate( wfTimestamp( TS_MW, $start_date ), true /* adjust? */ )
369367 );
370368
371 - $ret .= '<div id="ajaxpoll-info-' . $ID . '" class="ajaxpoll-info">' . $pollSummary . '</div>';
372 -
373 - $ret .= '</div>';
 369+ $ret .= '<div id="ajaxpoll-info-' . $ID . '" class="ajaxpoll-info">' . $pollSummary . '<div class="ajaxpoll-id-info">poll-id ' . $ID . '</div></div></div>';
374370 } else {
375371 $ret = '';
376372 }
Index: trunk/extensions/AJAXPoll/AJAXPoll.php
@@ -19,7 +19,7 @@
2020 * @author Jack Phoenix <jack@countervandalism.net>
2121 * @author Thomas Gries
2222 * @maintainer Thomas Gries
23 - * @version 1.64
 23+ * @version 1.65
2424 * @link http://www.mediawiki.org/wiki/Extension:AJAX_Poll Documentation
2525 */
2626
@@ -31,7 +31,7 @@
3232 $wgExtensionCredits['parserhook'][] = array(
3333 'path' => __FILE__,
3434 'name' => 'AJAX Poll',
35 - 'version' => '1.64 20120312',
 35+ 'version' => '1.65 20120312',
3636 'author' => array( 'Dariusz Siedlecki', 'Jack Phoenix', 'Thomas Gries' ),
3737 'descriptionmsg' => 'ajaxpoll-desc',
3838 'url' => 'https://www.mediawiki.org/wiki/Extension:AJAX_Poll',
Index: trunk/extensions/AJAXPoll/AJAXPoll.css
@@ -90,3 +90,9 @@
9191 margin-top: 20px;
9292 color: grey;
9393 }
 94+
 95+.ajaxpoll .ajaxpoll-id-info {
 96+ color:#FAFAFA;
 97+ font-size: 100%;
 98+ float: right;
 99+}

Status & tagging log