r113629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113628‎ | r113629 | r113630 >
Date:16:49, 12 March 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Bugfixes to r113622
Modified paths:
  • /trunk/extensions/Translate/api/ApiAggregateGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/api/ApiAggregateGroups.php
@@ -28,7 +28,7 @@
2929
3030 $params = $this->extractRequestParams();
3131 $aggregateGroup = $params['aggregategroup'];
32 - $action = $action;
 32+ $action = $params['do'];
3333
3434 if ( $action === 'associate' || $action === 'dissociate' ) {
3535 // Group is mandatory only for these two actions
@@ -55,7 +55,7 @@
5656 $subgroups[] = $group;
5757 $subgroups = array_unique( $subgroups );
5858 } elseif ( $action === 'dissociate' ) {
59 - $subgroups = array_flip( explode( ',', $subgroups ) ) ;
 59+ $subgroups = array_flip( $subgroups ) ;
6060 unset( $subgroups[$group] );
6161 $subgroups = array_flip( $subgroups );
6262 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113622Cleanup pass for my pedantic mind :)...nikerabbit13:12, 12 March 2012

Status & tagging log