r113611 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r113610‎ \| r113611 \| r113612 >
Date:	05:24, 12 March 2012
Author:	dantman
Status:	ok
Tags:
Comment:	Revert r113610, it appears it's impossible to fix vector in a sane way. If we try to fix it without images then the white in the version with images that's supposed to be there disappears. And that can't be fixed because that part of vector uses a variable em height disabling the ability to fix the issue by editing the uploaded image.
Modified paths:	/trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
—	—	@@ -40,6 +40,7 @@
41	41	/* Head */
42	42	#mw-page-base {
43	43	height: 5em;
	44	+ background-color: white;
44	45	/* @embed */
45	46	background-image: url(images/page-fade.png);
46	47	background-position: bottom left;
—	—	@@ -155,7 +156,6 @@
156	157	display: block;
157	158	}
158	159	div.vectorTabs li.selected {
159		~~- background-color: white;~~
160	160	/* @embed */
161	161	background-image: url(images/tab-current-fade.png);
162	162	}

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r113610	Tweak background colours in Vector's css so that Vector looks sane when image...	dantman	04:34, 12 March 2012

Status & tagging log

07:41, 12 March 2012 Raymond (talk | contribs) changed the status of r113611 [removed: new added: ok]