r113562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113561‎ | r113562 | r113563 >
Date:13:39, 10 March 2012
Author:wikinaut
Status:ok
Tags:
Comment:
version 1.002 added missing system text 'right-openid-converter-access'
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)
  • /trunk/extensions/OpenID/OpenID.php (modified) (history)
  • /trunk/extensions/OpenID/README.OpenID-mediawiki-extension (modified) (history)
  • /trunk/extensions/OpenID/TODO (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.i18n.php
@@ -135,6 +135,7 @@
136136 'openid-provider-label-other-username' => 'Enter your $1 username',
137137
138138 'specialpages-group-openid' => 'OpenID service pages and status information',
 139+ 'right-openid-converter-access' => 'Can add or convert their account to use OpenID identities',
139140 'right-openid-dashboard-access' => 'Standard access to the OpenID dashboard',
140141 'right-openid-dashboard-admin' => 'Administrator access to the OpenID dashboard',
141142
Index: trunk/extensions/OpenID/README.OpenID-mediawiki-extension
@@ -461,6 +461,7 @@
462462 into that account now
463463
464464 == CHANGES ==
 465+* 1.002 added missing system text 'right-openid-converter-access'
465466 * 1.001 convenience release with download of the version for PHP 5.3.x
466467 from https://github.com/Wikinaut/php-openid/tree/mw-extension-openid
467468 * 1.000 release version
Index: trunk/extensions/OpenID/OpenID.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '1.001 20120220' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '1.002 20120310' );
3232
3333 $path = dirname( __FILE__ );
3434 set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );
Index: trunk/extensions/OpenID/TODO
@@ -23,7 +23,7 @@
2424 - keep user from setting password in OpenID account except case S/OO
2525 - OpenID-only enabled account owners cannot set their password when the account
2626 lacks an e-mail address - which cannot be set up because they don't have a
27 - password (rat race condition)
 27+ password (race condition)
2828 https://bugzilla.wikimedia.org/show_bug.cgi?id=34357
2929 This is a regression from implementation of
3030 Changing your email address should require entering your password
@@ -38,7 +38,6 @@
3939 - configurable regexps for finding a user ID from an OpenID.
4040 - deal with difference between canonical ID and "display ID" with XRIs
4141 - support RP discovery
42 -- README (always keep README up to date)
4342
4443 * warn if a user account has been used as a login before attaching an
4544 OpenID (I think, this is solved; marked with * instead of +)

Status & tagging log