r113543 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113542‎ | r113543 | r113544 >
Date:23:23, 9 March 2012
Author:siebrand
Status:ok
Tags:i18nreview 
Comment:
Add message keys for 18 missing summary messages.
* Patch for bug 34319 for Special:DeletedContributions and Special:Contributions contributed by Srikanth Lakshmanan
* Other 16 instances identified by Der Umherirrende on translatewiki.net (https://translatewiki.net/wiki/Thread:Support/Missing_summary_message_keys_in_message_files), code updates by me.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -431,6 +431,7 @@
432432 'userloginnocreate',
433433 'logout',
434434 'userlogout',
 435+ 'userlogout-summary',
435436 'notloggedin',
436437 'nologin',
437438 'nologinlink',
@@ -538,6 +539,7 @@
539540 ),
540541 'changeemail' => array(
541542 'changeemail',
 543+ 'changeemail-summary',
542544 'changeemail-header',
543545 'changeemail-text',
544546 'changeemail-no-info',
@@ -925,6 +927,7 @@
926928 'prefsnologin',
927929 'prefsnologintext',
928930 'changepassword',
 931+ 'changepassword-summary',
929932 'prefs-skin',
930933 'skin-preview',
931934 'datedefault',
@@ -1628,7 +1631,9 @@
16291632 'uncategorizedtemplates',
16301633 'uncategorizedtemplates-summary',
16311634 'unusedcategories',
 1635+ 'unusedcategories-summary',
16321636 'unusedimages',
 1637+ 'unusedimages-summary',
16331638 'popularpages',
16341639 'popularpages-summary',
16351640 'wantedcategories',
@@ -1748,11 +1753,13 @@
17491754 ),
17501755 'deletedcontribs' => array(
17511756 'deletedcontributions',
 1757+ 'deletedcontributions-summary',
17521758 'deletedcontributions-title',
17531759 'sp-deletedcontributions-contribs',
17541760 ),
17551761 'linksearch' => array(
17561762 'linksearch',
 1763+ 'linksearch-summary',
17571764 'linksearch-pat',
17581765 'linksearch-ns',
17591766 'linksearch-ok',
@@ -1805,6 +1812,7 @@
18061813 'mailnologin',
18071814 'mailnologintext',
18081815 'emailuser',
 1816+ 'emailuser-summary',
18091817 'emailpage',
18101818 'emailpagetext',
18111819 'usermailererror',
@@ -1987,6 +1995,7 @@
19881996 ),
19891997 'undelete' => array(
19901998 'undelete',
 1999+ 'undelete-summary',
19912000 'undeletepage',
19922001 'undeletepagetitle',
19932002 'viewdeletedpage',
@@ -2037,6 +2046,7 @@
20382047 ),
20392048 'contributions' => array(
20402049 'contributions',
 2050+ 'contributions-summary',
20412051 'contributions-title',
20422052 'mycontris',
20432053 'contribsub2',
@@ -2089,6 +2099,7 @@
20902100 'autoblockid',
20912101 'block',
20922102 'unblock',
 2103+ 'unblock-summary',
20932104 'blockip',
20942105 'blockip-title',
20952106 'blockip-legend',
@@ -2220,6 +2231,7 @@
22212232 ),
22222233 'movepage' => array(
22232234 'move-page',
 2235+ 'movepage-summary',
22242236 'move-page-legend',
22252237 'movepagetext',
22262238 'movepagetext-noredirectfixer',
@@ -2281,6 +2293,7 @@
22822294 ),
22832295 'export' => array(
22842296 'export',
 2297+ 'export-summary',
22852298 'exporttext',
22862299 'exportall',
22872300 'exportcuronly',
@@ -2327,6 +2340,7 @@
23282341 ),
23292342 'import' => array(
23302343 'import',
 2344+ 'import-summary',
23312345 'importinterwiki',
23322346 'import-interwiki-text',
23332347 'import-interwiki-source',
@@ -3340,6 +3354,7 @@
33413355 'confirm-watch-button',
33423356 ),
33433357 'watchlisteditor' => array(
 3358+ 'editwatchlist-summary',
33443359 'watchlistedit-numitems',
33453360 'watchlistedit-noitems',
33463361 'watchlistedit-normal-title',
@@ -3430,6 +3445,7 @@
34313446 ),
34323447 'version' => array(
34333448 'version',
 3449+ 'version-summary',
34343450 'version-extensions',
34353451 'version-specialpages',
34363452 'version-parserhooks',
@@ -3498,6 +3514,7 @@
34993515 ),
35003516 'special-tags' => array(
35013517 'tags',
 3518+ 'tags-summary',
35023519 'tag-filter',
35033520 'tag-filter-submit',
35043521 'tags-title',
@@ -3511,6 +3528,7 @@
35123529 ),
35133530 'comparepages' => array(
35143531 'comparepages',
 3532+ 'comparepages-summary',
35153533 'compare-selector',
35163534 'compare-page1',
35173535 'compare-page2',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -218,6 +218,24 @@
219219 'deletedarticle',
220220 // 'uploadedimage',
221221 // 'overwroteimage',
 222+ 'userlogout-summary',
 223+ 'changeemail-summary',
 224+ 'changepassword-summary',
 225+ 'unusedcategories-summary',
 226+ 'unusedimages-summary',
 227+ 'deletedcontributions-summary',
 228+ 'linksearch-summary',
 229+ 'emailuser-summary',
 230+ 'undelete-summary',
 231+ 'contributions-summary',
 232+ 'unblock-summary',
 233+ 'movepage-summary',
 234+ 'export-summary',
 235+ 'import-summary',
 236+ 'editwatchlist-summary',
 237+ 'version-summary',
 238+ 'tags-summary',
 239+ 'comparepages-summary',
222240 );
223241
224242 /** Optional messages, which may be translated only if changed in the target language. */
Index: trunk/phase3/CREDITS
@@ -8,7 +8,7 @@
99 * Alexandre Emsenhuber
1010 * Andrew Garrett
1111 * Aryeh Gregor
12 -* Antoine Musso
 12+* Antoine Musso
1313 * Brian Wolff
1414 * Bertrand Grondin
1515 * Brad Jorsch
@@ -176,6 +176,7 @@
177177 * Simon Walker
178178 * Solitarius
179179 * Søren Løvborg
 180+* Srikanth Lakshmanan
180181 * Stefano Codari
181182 * Str4nd
182183 * svip
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -260,6 +260,7 @@
261261 function execute( $par ) {
262262 global $wgQueryPageDefaultLimit;
263263 $this->setHeaders();
 264+ $this->outputHeader();
264265
265266 $user = $this->getUser();
266267
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1062,6 +1062,7 @@
10631063 'userloginnocreate' => 'Log in',
10641064 'logout' => 'Log out',
10651065 'userlogout' => 'Log out',
 1066+'userlogout-summary' => '', # do not translate or duplicate this message to other languages
10661067 'notloggedin' => 'Not logged in',
10671068 'nologin' => "Don't have an account? $1.",
10681069 'nologinlink' => 'Create an account',
@@ -1228,6 +1229,7 @@
12291230
12301231 # Special:ChangeEmail
12311232 'changeemail' => 'Change e-mail address',
 1233+'changeemail-summary' => '', # do not translate or duplicate this message to other languages
12321234 'changeemail-header' => 'Change account e-mail address',
12331235 'changeemail-text' => 'Complete this form to change your e-mail address. You will need to enter your password to confirm this change.',
12341236 'changeemail-no-info' => 'You must be logged in to access this page directly.',
@@ -1764,6 +1766,7 @@
17651767 'prefsnologin' => 'Not logged in',
17661768 'prefsnologintext' => 'You must be <span class="plainlinks">[{{fullurl:{{#Special:UserLogin}}|returnto=$1}} logged in]</span> to set user preferences.',
17671769 'changepassword' => 'Change password',
 1770+'changepassword-summary' => '', # do not translate or duplicate this message to other languages
17681771 'prefs-skin' => 'Skin',
17691772 'skin-preview' => 'Preview',
17701773 'datedefault' => 'No preference',
@@ -2537,7 +2540,9 @@
25382541 'uncategorizedtemplates' => 'Uncategorized templates',
25392542 'uncategorizedtemplates-summary' => '', # do not translate or duplicate this message to other languages
25402543 'unusedcategories' => 'Unused categories',
 2544+'unusedcategories-summary' => '', # do not translate or duplicate this message to other languages
25412545 'unusedimages' => 'Unused files',
 2546+'unusedimages-summary' => '', # do not translate or duplicate this message to other languages
25422547 'popularpages' => 'Popular pages',
25432548 'popularpages-summary' => '', # do not translate or duplicate this message to other languages
25442549 'wantedcategories' => 'Wanted categories',
@@ -2662,19 +2667,21 @@
26632668
26642669 # Special:DeletedContributions
26652670 'deletedcontributions' => 'Deleted user contributions',
 2671+'deletedcontributions-summary' => '', # do not translate or duplicate this message to other languages
26662672 'deletedcontributions-title' => 'Deleted user contributions',
26672673 'sp-deletedcontributions-contribs' => 'contributions',
26682674
26692675 # Special:LinkSearch
2670 -'linksearch' => 'External links search',
2671 -'linksearch-pat' => 'Search pattern:',
2672 -'linksearch-ns' => 'Namespace:',
2673 -'linksearch-ok' => 'Search',
2674 -'linksearch-text' => 'Wildcards such as "*.wikipedia.org" may be used.
 2676+'linksearch' => 'External links search',
 2677+'linksearch-summary' => '', # do not translate or duplicate this message to other languages
 2678+'linksearch-pat' => 'Search pattern:',
 2679+'linksearch-ns' => 'Namespace:',
 2680+'linksearch-ok' => 'Search',
 2681+'linksearch-text' => 'Wildcards such as "*.wikipedia.org" may be used.
26752682 Needs at least a top-level domain, for example "*.org".<br />
26762683 Supported protocols: <tt>$1</tt> (do not add any of these in your search).',
2677 -'linksearch-line' => '$1 is linked from $2',
2678 -'linksearch-error' => 'Wildcards may appear only at the start of the hostname.',
 2684+'linksearch-line' => '$1 is linked from $2',
 2685+'linksearch-error' => 'Wildcards may appear only at the start of the hostname.',
26792686
26802687 # Special:ListUsers
26812688 'listusersfrom' => 'Display users starting at:',
@@ -2721,6 +2728,7 @@
27222729 'mailnologin' => 'No send address',
27232730 'mailnologintext' => 'You must be [[Special:UserLogin|logged in]] and have a valid e-mail address in your [[Special:Preferences|preferences]] to send e-mail to other users.',
27242731 'emailuser' => 'E-mail this user',
 2732+'emailuser-summary' => '', # do not translate or duplicate this message to other languages
27252733 'emailpage' => 'E-mail user',
27262734 'emailpagetext' => 'You can use the form below to send an e-mail message to this user.
27272735 The e-mail address you entered in [[Special:Preferences|your user preferences]] will appear as the "From" address of the e-mail, so the recipient will be able to reply directly to you.',
@@ -2957,6 +2965,7 @@
29582966
29592967 # Undelete
29602968 'undelete' => 'View deleted pages',
 2969+'undelete-summary' => '', # do not translate or duplicate this message to other languages
29612970 'undeletepage' => 'View and restore deleted pages',
29622971 'undeletepagetitle' => "'''The following consists of deleted revisions of [[:$1|$1]]'''.",
29632972 'viewdeletedpage' => 'View deleted pages',
@@ -3019,14 +3028,15 @@
30203029 'blanknamespace' => '(Main)',
30213030
30223031 # Contributions
3023 -'contributions' => 'User contributions',
3024 -'contributions-title' => 'User contributions for $1',
3025 -'mycontris' => 'My contributions',
3026 -'contribsub2' => 'For $1 ($2)',
3027 -'nocontribs' => 'No changes were found matching these criteria.',
3028 -'uctop' => '(top)',
3029 -'month' => 'From month (and earlier):',
3030 -'year' => 'From year (and earlier):',
 3032+'contributions' => 'User contributions',
 3033+'contributions-summary' => '', # do not translate or duplicate this message to other languages
 3034+'contributions-title' => 'User contributions for $1',
 3035+'mycontris' => 'My contributions',
 3036+'contribsub2' => 'For $1 ($2)',
 3037+'nocontribs' => 'No changes were found matching these criteria.',
 3038+'uctop' => '(top)',
 3039+'month' => 'From month (and earlier):',
 3040+'year' => 'From year (and earlier):',
30313041
30323042 'sp-contributions-newbies' => 'Show contributions of new accounts only',
30333043 'sp-contributions-newbies-sub' => 'For new accounts',
@@ -3073,6 +3083,7 @@
30743084 'autoblockid' => 'Autoblock #$1',
30753085 'block' => 'Block user',
30763086 'unblock' => 'Unblock user',
 3087+'unblock-summary' => '', # do not translate or duplicate this message to other languages
30773088 'blockip' => 'Block user',
30783089 'blockip-title' => 'Block user',
30793090 'blockip-legend' => 'Block user',
@@ -3226,6 +3237,7 @@
32273238
32283239 # Move page
32293240 'move-page' => 'Move $1',
 3241+'movepage-summary' => '', # do not translate or duplicate this message to other languages
32303242 'move-page-legend' => 'Move page',
32313243 'movepagetext' => "Using the form below will rename a page, moving all of its history to the new name.
32323244 The old title will become a redirect page to the new title.
@@ -3320,6 +3332,7 @@
33213333
33223334 # Export
33233335 'export' => 'Export pages',
 3336+'export-summary' => '', # do not translate or duplicate this message to other languages
33243337 'exporttext' => 'You can export the text and editing history of a particular page or set of pages wrapped in some XML.
33253338 This can be imported into another wiki using MediaWiki via the [[Special:Import|import page]].
33263339
@@ -3373,6 +3386,7 @@
33743387
33753388 # Special:Import
33763389 'import' => 'Import pages',
 3390+'import-summary' => '', # do not translate or duplicate this message to other languages
33773391 'importinterwiki' => 'Transwiki import',
33783392 'import-interwiki-text' => "Select a wiki and page title to import.
33793393 Revision dates and editors' names will be preserved.
@@ -4461,6 +4475,7 @@
44624476 'lag-warn-high' => 'Due to high database server lag, changes newer than $1 {{PLURAL:$1|second|seconds}} may not be shown in this list.',
44634477
44644478 # Watchlist editor
 4479+'editwatchlist-summary' => '', # do not translate or duplicate this message to other languages
44654480 'watchlistedit-numitems' => 'Your watchlist contains {{PLURAL:$1|1 title|$1 titles}}, excluding talk pages.',
44664481 'watchlistedit-noitems' => 'Your watchlist contains no titles.',
44674482 'watchlistedit-normal-title' => 'Edit watchlist',
@@ -4556,6 +4571,7 @@
45574572
45584573 # Special:Version
45594574 'version' => 'Version',
 4575+'version-summary' => '', # do not translate or duplicate this message to other languages
45604576 'version-extensions' => 'Installed extensions',
45614577 'version-specialpages' => 'Special pages',
45624578 'version-parserhooks' => 'Parser hooks',
@@ -4638,6 +4654,7 @@
46394655
46404656 # Special:Tags
46414657 'tags' => 'Valid change tags',
 4658+'tags-summary' => '', # do not translate or duplicate this message to other languages
46424659 'tag-filter' => '[[Special:Tags|Tag]] filter:',
46434660 'tag-filter-submit' => 'Filter',
46444661 'tags-title' => 'Tags',
@@ -4651,6 +4668,7 @@
46524669
46534670 # Special:ComparePages
46544671 'comparepages' => 'Compare pages',
 4672+'comparepages-summary' => '', # do not translate or duplicate this message to other languages
46554673 'compare-selector' => 'Compare page revisions',
46564674 'compare-page1' => 'Page 1',
46574675 'compare-page2' => 'Page 2',

Sign-offs

UserFlagDate
Krinkleinspected04:13, 12 March 2012

Status & tagging log