r113539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113538‎ | r113539 | r113540 >
Date:22:55, 9 March 2012
Author:tparscal
Status:deferred
Tags:
Comment:
More cleanup
Modified paths:
  • /trunk/extensions/VisualEditor/modules/ve/ce/ve.ce.Surface.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/ve/ce/ve.ce.Surface.js
@@ -541,7 +541,6 @@
542542 node: item,
543543 offset: offset - nodeOffset
544544 };
545 - break;
546545 } else {
547546 nodeOffset += length;
548547 }
@@ -574,8 +573,9 @@
575574 ve.ce.Surface.prototype.showSelection = function( range ) {
576575 var start = this.getDOMNodeAndOffset( range.start ),
577576 stop = this.getDOMNodeAndOffset( range.end ),
578 - range = rangy.createRange(),
579577 sel = rangy.getSelection();
 578+ // FIXME: Shadowing range, really?
 579+ range = rangy.createRange();
580580 range.setStart( start.node, start.offset );
581581 range.setEnd( stop.node, stop.offset );
582582 sel.setSingleRange( range );

Status & tagging log