r113414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113413‎ | r113414 | r113415 >
Date:22:37, 8 March 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/FileOp.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/filerepo/backend/FileOp.php
@@ -143,13 +143,12 @@
144144 } else {
145145 $status->success[$index] = false;
146146 ++$status->failCount;
147 - if ( !$ignoreErrors ) {
148 - // Log remaining ops as failed for recovery...
149 - for ( $i = ($index + 1); $i < count( $performOps ); $i++ ) {
150 - $performOps[$i]->logFailure( 'attempt_aborted' );
151 - }
152 - return $status; // bail out
 147+ // We can't continue (even with $ignoreErrors) as $predicates is wrong.
 148+ // Log the remaining ops as failed for recovery...
 149+ for ( $i = ($index + 1); $i < count( $performOps ); $i++ ) {
 150+ $performOps[$i]->logFailure( 'attempt_aborted' );
153151 }
 152+ return $status; // bail out
154153 }
155154 }
156155
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
157156 Merged /trunk/phase3/includes:r113195
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
158157 Merged /trunk/phase3:r113195

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113195Fixed FileOp::attemptBatch() behavior when unexpected failures occur with the...aaron22:59, 6 March 2012

Status & tagging log