r113368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113367‎ | r113368 | r113369 >
Date:16:34, 8 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1/extensions (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/ExtensionDistributor (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -227,9 +227,12 @@
228228 // Does the tar file need ExtensionFunctions.php?
229229 $dir = "$wgExtDistWorkingCopy/$version/extensions/$extension";
230230 $retval = - 1;
231 - $files = call_user_func_array( 'wfEscapeShellArg', glob( "$dir/*.php" ) );
232 - wfShellExec( "grep -q '\bExtensionFunctions' " . $files, $retval );
233 - $needEF = !$retval;
 231+ $needEF = false;
 232+ if ( file_exists( 'ExtensionFunctions.php' ) ) {
 233+ $files = call_user_func_array( 'wfEscapeShellArg', glob( "$dir/*.php" ) );
 234+ wfShellExec( "grep -q '\bExtensionFunctions' " . $files, $retval );
 235+ $needEF = !$retval;
 236+ }
234237
235238 // Create the archive.
236239 $cmd = 'tar -czf ' . wfEscapeShellArg( $tarFile ) .
Property changes on: branches/wmf/1.19wmf1/extensions/ExtensionDistributor
___________________________________________________________________
Modified: svn:mergeinfo
237240 Merged /trunk/extensions/ExtensionDistributor:r113367
Property changes on: branches/wmf/1.19wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
238241 Merged /trunk/extensions:r113367

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113367Bug 27246 - Downloading trunk version of ExtensionDistributor gives error...reedy16:33, 8 March 2012

Status & tagging log