r113349 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r113348‎ \| r113349 \| r113350 >
Date:	08:34, 8 March 2012
Author:	santhosh
Status:	resolved (Comments)
Tags:
Comment:	* Minor whitespace fix in mediawiki.language.js * Use mw.language.getData in all language js files instead of directling accessing from mw.language.data based on the fixes in r112991
Modified paths:	/branches/jsgrammar/resources/mediawiki.language/languages/bs.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/dsb.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/fi.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/ga.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/he.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/hsb.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/hu.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/hy.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/la.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/os.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/ru.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/sl.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/languages/uk.js (modified) (history) /branches/jsgrammar/resources/mediawiki.language/mediawiki.language.js (modified) (history)

Diff [purge]

Index: branches/jsgrammar/resources/mediawiki.language/mediawiki.language.js
—	—	@@ -68,7 +68,7 @@
69	69	procPLURAL: function ( template ) {
70	70	var count;
71	71
72		~~- if ( template.title && template.parameters ) {~~
	72	+ if ( template.title && template.parameters ) {
73	73	// Check if we have forms to replace
74	74	if ( template.parameters.length === 0 ) {
75	75	return '';
Index: branches/jsgrammar/resources/mediawiki.language/languages/bs.js
—	—	@@ -20,8 +20,9 @@
21	21	};
22	22
23	23	mediaWiki.language.convertGrammar = function( word, form ) {
24		~~- var grammarForms = mw.language.data[ 'bs' ].get( 'grammarForms' );~~
	24	+ var grammarForms = mw.language.getData( 'bs', 'grammarForms' );
25	25	if ( grammarForms && grammarForms[form] ) {
	26	+ if ( grammarForms && grammarForms[form] ) {
26	27	return grammarForms[form][word] ;
27	28	}
28	29	switch ( form ) {
Index: branches/jsgrammar/resources/mediawiki.language/languages/dsb.js
—	—	@@ -18,7 +18,7 @@
19	19	};
20	20
21	21	mediaWiki.language.convertGrammar = function( word, form ) {
22		~~- var grammarForms = mw.language.data[ 'dsb' ].get( 'grammarForms' );~~
	22	+ var grammarForms = mw.language.getData( 'dsb', 'grammarForms' );
23	23	if ( grammarForms && grammarForms[form] ) {
24	24	return grammarForms[form][word] ;
25	25	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/hu.js
—	—	@@ -4,7 +4,7 @@
5	5	*/
6	6
7	7	mediaWiki.language.convertGrammar = function( word, form ) {
8		~~- var grammarForms = mw.language.data[ 'hu' ].get( 'grammarForms' );~~
	8	+ var grammarForms =mw.language.getData( 'hu', 'grammarForms' );
9	9	if ( grammarForms && grammarForms[form] ) {
10	10	return grammarForms[form][word] ;
11	11	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/hsb.js
—	—	@@ -19,7 +19,7 @@
20	20
21	21
22	22	mediaWiki.language.convertGrammar = function( word, form ) {
23		~~- var grammarForms = mw.language.data[ 'hsb' ].get( 'grammarForms' );~~
	23	+ var grammarForms =mw.language.getData( 'hsb', 'grammarForms' );
24	24	if ( grammarForms && grammarForms[form] ) {
25	25	return grammarForms[form][word] ;
26	26	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/uk.js
—	—	@@ -23,7 +23,7 @@
24	24	};
25	25
26	26	mediaWiki.language.convertGrammar = function( word, form ) {
27		~~- var grammarForms = mw.language.data[ 'uk' ].get( 'grammarForms' );~~
	27	+ var grammarForms = mw.language.getData( 'uk', 'grammarForms' );
28	28	if ( grammarForms && grammarForms[form] ) {
29	29	return grammarForms[form][word] ;
30	30	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/hy.js
—	—	@@ -8,7 +8,7 @@
9	9	};
10	10
11	11	mediaWiki.language.convertGrammar = function( word, form ) {
12		~~- var grammarForms = mw.language.data[ 'hy' ].get( 'grammarForms' );~~
	12	+ var grammarForms = mw.language.getData( 'hy', 'grammarForms' );
13	13	if ( grammarForms && grammarForms[form] ) {
14	14	return grammarForms[form][word] ;
15	15	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/os.js
—	—	@@ -5,7 +5,7 @@
6	6
7	7
8	8	mediaWiki.language.convertGrammar = function( word, form ) {
9		~~- var grammarForms = mw.language.data[ 'os' ].get( 'grammarForms' );~~
	9	+ var grammarForms = mw.language.getData( 'os', 'grammarForms' );
10	10	if ( grammarForms && grammarForms[form] ) {
11	11	return grammarForms[form][word] ;
12	12	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/ru.js
—	—	@@ -23,7 +23,7 @@
24	24	};
25	25
26	26	mediaWiki.language.convertGrammar = function( word, form ) {
27		~~- var grammarForms = mw.language.data[ 'ru' ].get( 'grammarForms' );~~
	27	+ var grammarForms = mw.language.getData( 'ru', 'grammarForms' );
28	28	if ( grammarForms && grammarForms[form] ) {
29	29	return grammarForms[form][word] ;
30	30	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/sl.js
—	—	@@ -20,7 +20,7 @@
21	21	};
22	22
23	23	mediaWiki.language.convertGrammar = function( word, form ) {
24		~~- var grammarForms = mw.language.data[ 'sl' ].get( 'grammarForms' );~~
	24	+ var grammarForms = mw.language.getData( 'sl', 'grammarForms' );
25	25	if ( grammarForms && grammarForms[form] ) {
26	26	return grammarForms[form][word] ;
27	27	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/ga.js
—	—	@@ -15,7 +15,7 @@
16	16
17	17
18	18	mediaWiki.language.convertGrammar = function( word, form ) {
19		~~- var grammarForms = mw.language.data[ 'ga' ].get( 'grammarForms' );~~
	19	+ var grammarForms = mw.language.getData( 'ga', 'grammarForms' );
20	20	if ( grammarForms && grammarForms[form] ) {
21	21	return grammarForms[form][word] ;
22	22	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/la.js
—	—	@@ -4,7 +4,7 @@
5	5	*/
6	6
7	7	mediaWiki.language.convertGrammar = function( word, form ) {
8		~~- var grammarForms = mw.language.data[ 'la' ].get( 'grammarForms' );~~
	8	+ var grammarForms = mw.language.getData( 'la', 'grammarForms' );
9	9	if ( grammarForms && grammarForms[form] ) {
10	10	return grammarForms[form][word] ;
11	11	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/he.js
—	—	@@ -14,7 +14,7 @@
15	15	};
16	16
17	17	mediaWiki.language.convertGrammar = function( word, form ) {
18		~~- var grammarForms = mw.language.data[ 'he' ].get( 'grammarForms' );~~
	18	+ var grammarForms = mw.language.getData( 'he', 'grammarForms' );
19	19	if ( grammarForms && grammarForms[form] ) {
20	20	return grammarForms[form][word] ;
21	21	}
Index: branches/jsgrammar/resources/mediawiki.language/languages/fi.js
—	—	@@ -4,7 +4,7 @@
5	5	*/
6	6
7	7	mediaWiki.language.convertGrammar = function( word, form ) {
8		~~- var grammarForms = mw.language.data[ 'fi' ].get( 'grammarForms' );~~
	8	+ var grammarForms = mw.language.getData( 'fi', 'grammarForms' );
9	9	if ( grammarForms && grammarForms[form] ) {
10	10	return grammarForms[form][word] ;
11	11	}

Follow-up revisions

Revision	Commit summary	Author	Date
r113354	Remove duplicated line added in r113349 by mistake.	santhosh	10:18, 8 March 2012
r113355	Whitespace fixes. Ping r113349	santhosh	10:20, 8 March 2012

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r112991	[JSGrammar] Various minor tips, tricks and clean up....	krinkle	23:56, 4 March 2012

Comments

#Comment by Krinkle (talk | contribs) 10:10, 8 March 2012

-	var grammarForms = mw.language.data[ 'hu' ].get( 'grammarForms' );
+	var grammarForms =mw.language.getData( 'hu', 'grammarForms' );

-	var grammarForms = mw.language.data[ 'ru' ].get( 'grammarForms' );
+		var grammarForms = mw.language.getData( 'ru', 'grammarForms' );

minor whitespace and indention nag.

Index: branches/jsgrammar/resources/mediawiki.language/languages/bs.js
—	—	@@ -20,8 +20,9 @@
mediaWiki.language.convertGrammar = function( word, form ) {
-	var grammarForms = mw.language.data[ 'bs' ].get( 'grammarForms' );
+	var grammarForms = mw.language.getData( 'bs', 'grammarForms' );
	if ( grammarForms && grammarForms[form] ) {
+	if ( grammarForms && grammarForms[form] ) {
		return grammarForms[form][word] ;
	}
	switch ( form ) {

Duplicated if-statement, throwing exception SyntaxError: Unexpected end of input (marking fixme).

Status & tagging log

11:02, 8 March 2012 Krinkle (talk | contribs) changed the status of r113349 [removed: new added: resolved]
10:21, 8 March 2012 Santhosh.thottingal (talk | contribs) changed the status of r113349 [removed: fixme added: new]
10:10, 8 March 2012 Krinkle (talk | contribs) changed the status of r113349 [removed: new added: fixme]