r113278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113277‎ | r113278 | r113279 >
Date:19:36, 7 March 2012
Author:catrope
Status:ok
Tags:
Comment:
1.19wmf1: MFT r113277
Modified paths:
  • /branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderModule.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderModule.php
@@ -357,6 +357,10 @@
358358 * timestamps. Whenever anything happens that changes the module's
359359 * contents for these parameters, the mtime should increase.
360360 *
 361+ * NOTE: The mtime of the module's messages is NOT automatically included.
 362+ * If you want this to happen, you'll need to call getMsgBlobMtime()
 363+ * yourself and take its result into consideration.
 364+ *
361365 * @param $context ResourceLoaderContext: Context object
362366 * @return Integer: UNIX timestamp
363367 */
Index: branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderWikiModule.php
@@ -157,6 +157,7 @@
158158 if ( count( $mtimes ) ) {
159159 $modifiedTime = max( $modifiedTime, max( $mtimes ) );
160160 }
 161+ $modifiedTime = max( $modifiedTime, $this->getMsgBlobMtime( $context->getLanguage() ) );
161162 return $modifiedTime;
162163 }
163164

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113277(bug 35036) Wikipage-based ResourceLoader modules were not automatically purg...catrope19:33, 7 March 2012

Status & tagging log