r113271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113270‎ | r113271 | r113272 >
Date:19:07, 7 March 2012
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r113142; fix incorrect conversion to array (value can be array already)
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
——@@ -1087,7 +1087,7 @@
10881088 $helptext = null;
10891089
10901090 if ( isset( $this->mParams['help-message'] ) ) {
1091 - $this->mParams['help-messages'] = (array)$this->mParams['help-message'];
 1091+ $this->mParams['help-messages'] = array( $this->mParams['help-message'] );
10921092 }
10931093
10941094 if ( isset( $this->mParams['help-messages'] ) ) {

Sign-offs

UserFlagDate
Rob Schnautz (WMF)tested19:38, 7 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113142follow up to r113113, get rid of code ducpliation and fix docs to reflect act...jeroendedauw15:36, 6 March 2012

Status & tagging log