r113240 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113239‎ | r113240 | r113241 >
Date:16:00, 7 March 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Calling the wrong group parameter broke gettext comments when reviewing recent translations
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -824,10 +824,10 @@
825825 if ( $ffs instanceof GettextFFS ) {
826826 global $wgContLang;
827827 $mykey = $wgContLang->lcfirst( $this->handle->getKey() );
828 - $data = $ffs->read( $this->group->getSourceLanguage() );
 828+ $data = $ffs->read( $group->getSourceLanguage() );
829829 $help = $data['TEMPLATE'][$mykey]['comments'];
830830 // Do not display an empty comment. That's no help and takes up unnecessary space.
831 - $conf = $this->group->getConfiguration();
 831+ $conf = $group->getConfiguration();
832832 if ( isset( $conf['BASIC']['codeBrowser'] ) ) {
833833 $out = '';
834834 $pattern = $conf['BASIC']['codeBrowser'];

Status & tagging log