r113220 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113219‎ | r113220 | r113221 >
Date:09:05, 7 March 2012
Author:zaran
Status:ok
Tags:
Comment:
Bug 34821 - Pages names were escaped twice, which created wrong queries for filenames with quotes
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1373,7 +1373,7 @@
13741374 if ( $image && $image->isMultipage() && $image->pageCount() ) {
13751375 $n = $image->pageCount();
13761376 for ( $i = 1; $i <= $n; $i++ ) {
1377 - $page = $dbr->strencode( $index_title->getDBKey() . '/' . $i );
 1377+ $page = $index_title->getDBKey() . '/' . $i;
13781378 if( $page != $deletedpage ) {
13791379 array_push( $pages, $page );
13801380 }
@@ -1383,7 +1383,7 @@
13841384 } else {
13851385 $n = count( $links[1] );
13861386 for ( $i = 0; $i < $n; $i++ ) {
1387 - $page = $dbr->strencode( str_replace( ' ' , '_' , $links[1][$i] ) );
 1387+ $page = str_replace( ' ' , '_' , $links[1][$i] );
13881388 if( $page != $deletedpage ) {
13891389 array_push( $pages, $page );
13901390 }

Status & tagging log