r113213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113212‎ | r113213 | r113214 >
Date:02:43, 7 March 2012
Author:krinkle
Status:ok
Tags:
Comment:
[jquery.textSelection.test] disable caretTest per bug 34820
* Right now it's causing testswarm clients to have to this test 3 times, and if until bug 34820 is fixed there is no point in clogging up testswarm with it, making all IE columns uselessly red and making it harder to detect an actual regression
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.textSelection.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.textSelection.test.js
——@@ -253,6 +253,8 @@
254254
255255 var caretSample = "Some big text that we like to work with. Nothing fancy... you know what I mean?";
256256
 257+/*
 258+ // @broken: Disabled per bug 34820
257259 caretTest({
258260 description: 'getCaretPosition with original/empty selection - bug 31847 with IE 6/7/8',
259261 text: caretSample,
——@@ -260,6 +262,7 @@
261263 end: [0, caretSample.length], // Other browsers default it to the beginning (0), so check both.
262264 mode: 'get'
263265 });
 266+*/
264267
265268 caretTest({
266269 description: 'set/getCaretPosition with forced empty selection',

Status & tagging log