r113185 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113184‎ | r113185 | r113186 >
Date:21:59, 6 March 2012
Author:catrope
Status:ok
Tags:
Comment:
Prevent massive confusion in case someone should try to set $implicit_hide to false
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiFlagFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiFlagFeedbackArticleFeedbackv5.php
@@ -379,7 +379,7 @@
380380 }
381381
382382 // handle implicit hide/show logging
383 - if ( isset( $implicit_hide )) {
 383+ if ( isset( $implicit_hide ) && $implicit_hide ) {
384384 ApiArticleFeedbackv5Utils::logActivity( 'hidden' , $pageId, $feedbackId, '', true);
385385 }
386386

Sign-offs

UserFlagDate
Nikerabbitinspected07:44, 7 March 2012

Status & tagging log