r113147 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113146‎ | r113147 | r113148 >
Date:16:21, 6 March 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
increment to 1.8 alpha and attempt to fix bug 34855
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/INSTALL (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/SemanticMediaWiki.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/INSTALL
@@ -1,4 +1,4 @@
2 -[[Semantic MediaWiki 1.7.1]]
 2+[[Semantic MediaWiki 1.8]]
33
44 Install instructions for the latest SMW version are also online in a more
55 convenient format for reading:
Index: trunk/extensions/SemanticMediaWiki/RELEASE-NOTES
@@ -1,6 +1,16 @@
22 For a documentation of all features, see http://semantic-mediawiki.org
33
44
 5+== SMW 1.8 ==
 6+
 7+THIS IS NOT A RELEASE YET
 8+
 9+Semantic MediaWiki 1.8 is currently in beta-quality and is not recommended for use in
 10+production until the actual release.
 11+
 12+* Dropped compatibility with MediaWiki 1.16.x (and earlier).
 13+* Full compatibility with MediaWiki 1.19 and foreward-compatibility with 1.20.
 14+
515 == SMW 1.7.1 ==
616
717 Released on March 5, 2012.
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -1060,10 +1060,10 @@
10611061 // we use a temporary table for executing this costly operation on the DB side
10621062 $smw_tmp_unusedprops = $db->tableName( 'smw_tmp_unusedprops' );
10631063 if ( $wgDBtype == 'postgres' ) { // PostgresQL: no in-memory tables available
1064 - $sql = "CREATE OR REPLACE FUNCTION create_" . $smw_tmp_unusedprops . "() RETURNS void AS "
 1064+ $sql = "CREATE OR REPLACE FUNCTION create_smw_tmp_unusedprops() RETURNS void AS "
10651065 . "$$ "
10661066 . "BEGIN "
1067 - . " IF EXISTS(SELECT NULL FROM pg_tables WHERE tablename='" . $smw_tmp_unusedprops . "' AND schemaname = ANY (current_schemas(true))) "
 1067+ . " IF EXISTS(SELECT NULL FROM pg_tables WHERE tablename=" . $smw_tmp_unusedprops . " AND schemaname = ANY (current_schemas(true))) "
10681068 . " THEN DELETE FROM " . $smw_tmp_unusedprops . "; "
10691069 . " ELSE "
10701070 . " CREATE TEMPORARY TABLE " . $smw_tmp_unusedprops . " ( title text ); "
@@ -1071,7 +1071,7 @@
10721072 . "END; "
10731073 . "$$ "
10741074 . "LANGUAGE 'plpgsql'; "
1075 - . "SELECT create_" . $smw_tmp_unusedprops . "(); ";
 1075+ . "SELECT create_smw_tmp_unusedprops(); ";
10761076 } else { // MySQL: use temporary in-memory table
10771077 $sql = "CREATE TEMPORARY TABLE " . $smw_tmp_unusedprops . "( title VARCHAR(255) ) ENGINE=MEMORY";
10781078 }
Index: trunk/extensions/SemanticMediaWiki/SemanticMediaWiki.php
@@ -19,8 +19,8 @@
2020 die( 'Not an entry point.' );
2121 }
2222
23 -if ( version_compare( $wgVersion, '1.16c', '<' ) ) {
24 - die( '<b>Error:</b> This version of Semantic MediaWiki requires MediaWiki 1.16 or above; use SMW 1.6.x for MediaWiki 1.15.x.' );
 23+if ( version_compare( $wgVersion, '1.17c', '<' ) ) {
 24+ die( '<b>Error:</b> This version of Semantic MediaWiki requires MediaWiki 1.17 or above; use SMW 1.7.x for MediaWiki 1.16.x.' );
2525 }
2626
2727 // Include the Validator extension if that hasn't been done yet, since it's required for SMW to work.
@@ -34,7 +34,7 @@
3535 }
3636
3737 // The SMW version number.
38 -define( 'SMW_VERSION', '1.7.1' );
 38+define( 'SMW_VERSION', '1.8 alpha' );
3939
4040 // Registration of the extension credits, see Special:Version.
4141 $wgExtensionCredits['semantic'][] = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r114764We don't want the quoted table name when we are doing a direct lookup via a c...greg14:01, 6 April 2012