r113145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113144‎ | r113145 | r113146 >
Date:16:04, 6 March 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/EducationProgram/includes/EPCAPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPOAPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/includes/EPCAPager.php
@@ -12,6 +12,7 @@
1313 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1414 */
1515 class EPCAPager extends EPOAPager {
 16+
1617 /**
1718 * Constructor.
1819 *
@@ -19,8 +20,7 @@
2021 * @param array $conds
2122 */
2223 public function __construct( IContextSource $context, array $conds = array() ) {
23 - parent::__construct( $context, $conds );
24 - $this->table = EPCAs::singleton();
 24+ parent::__construct( $context, $conds, EPCAs::singleton() );
2525 }
2626
2727 /**
Index: trunk/extensions/EducationProgram/includes/EPOAPager.php
@@ -18,10 +18,16 @@
1919 *
2020 * @param IContextSource $context
2121 * @param array $conds
 22+ * @param DBTable|null $table
2223 */
23 - public function __construct( IContextSource $context, array $conds = array() ) {
 24+ public function __construct( IContextSource $context, array $conds = array(), DBTable $table = null ) {
2425 $this->mDefaultDirection = true;
25 - parent::__construct( $context, $conds, EPOAs::singleton() );
 26+
 27+ parent::__construct(
 28+ $context,
 29+ $conds,
 30+ is_null( $table ) ? EPOAs::singleton() : $table
 31+ );
2632 }
2733
2834 /**

Sign-offs

UserFlagDate
Rob Schnautz (WMF)tested19:34, 7 March 2012

Status & tagging log