r112996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112995‎ | r112996 | r112997 >
Date:01:47, 5 March 2012
Author:krinkle
Status:ok
Tags:
Comment:
[mediawiki.test] follow-up r112368: Append to fixture instead of body. Otherwise it stays in the dom even after the test is done
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -190,8 +190,7 @@
191191
192192 equal( mw.loader.getState( 'test.implement' ), 'loaded', 'module state is "loaded" while implement() is executing javascript' );
193193
194 - $element = $( '<div class="mw-test-loaderimplement">Foo bar</div>' );
195 - $element.appendTo( 'body' );
 194+ $element = $( '<div class="mw-test-loaderimplement">Foo bar</div>' ).appendTo( '#qunit-fixture' );
196195
197196 // @broken: equal( $element.css( 'text-align' ),'center', 'CSS stylesheet was applied in time. ("text-align: center")' );
198197

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112368[JSTesting] Add more mw.loader tests...krinkle23:13, 24 February 2012

Status & tagging log