r112984 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112983‎ | r112984 | r112985 >
Date:21:08, 4 March 2012
Author:aaron
Status:ok
Tags:
Comment:
Added some super calls to constructors to be safe
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/lockmanager/DBLockManager.php (modified) (history)
  • /trunk/phase3/includes/filerepo/backend/lockmanager/FSLockManager.php (modified) (history)
  • /trunk/phase3/includes/filerepo/backend/lockmanager/LSLockManager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/lockmanager/DBLockManager.php
@@ -55,6 +55,8 @@
5656 * @param Array $config
5757 */
5858 public function __construct( array $config ) {
 59+ parent::__construct( $config );
 60+
5961 $this->dbServers = isset( $config['dbServers'] )
6062 ? $config['dbServers']
6163 : array(); // likely just using 'localDBMaster'
Index: trunk/phase3/includes/filerepo/backend/lockmanager/FSLockManager.php
@@ -35,6 +35,7 @@
3636 */
3737 function __construct( array $config ) {
3838 parent::__construct( $config );
 39+
3940 $this->lockDir = $config['lockDirectory'];
4041 }
4142
Index: trunk/phase3/includes/filerepo/backend/lockmanager/LSLockManager.php
@@ -50,6 +50,8 @@
5151 * @param Array $config
5252 */
5353 public function __construct( array $config ) {
 54+ parent::__construct( $config );
 55+
5456 $this->lockServers = $config['lockServers'];
5557 // Sanitize srvsByBucket config to prevent PHP errors
5658 $this->srvsByBucket = array_filter( $config['srvsByBucket'], 'is_array' );

Status & tagging log