r112967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112966‎ | r112967 | r112968 >
Date:05:15, 4 March 2012
Author:bawolff
Status:ok
Tags:
Comment:
(bug 28019) Make Special:MyPage and Special:MyTalk carry preloadtitle
url parameter to target page. Useful for inputbox extension.

Patch by Bagariavivek.

Perhaps should go through [[Manual:Parameters_to_index.php]] and add anything that's sane to the allowed list, at some point.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -87,6 +87,7 @@
8888 * Andrew Dunbar
8989 * Antonio Ospite
9090 * Azliq7
 91+* Bagariavivek
9192 * Beau
9293 * Bergi
9394 * Borislav Manolov
Index: trunk/phase3/includes/SpecialPage.php
@@ -1082,7 +1082,7 @@
10831083 class SpecialMypage extends RedirectSpecialPage {
10841084 function __construct() {
10851085 parent::__construct( 'Mypage' );
1086 - $this->mAllowedRedirectParams = array( 'action' , 'preload' , 'editintro',
 1086+ $this->mAllowedRedirectParams = array( 'action', 'preload', 'preloadtitle', 'editintro',
10871087 'section', 'oldid', 'diff', 'dir',
10881088 // Options for action=raw; missing ctype can break JS or CSS in some browsers
10891089 'ctype', 'maxage', 'smaxage' );
@@ -1104,7 +1104,7 @@
11051105 class SpecialMytalk extends RedirectSpecialPage {
11061106 function __construct() {
11071107 parent::__construct( 'Mytalk' );
1108 - $this->mAllowedRedirectParams = array( 'action' , 'preload' , 'editintro',
 1108+ $this->mAllowedRedirectParams = array( 'action', 'preload', 'preloadtitle', 'editintro',
11091109 'section', 'oldid', 'diff', 'dir' );
11101110 }
11111111
Index: trunk/phase3/RELEASE-NOTES-1.20
@@ -39,6 +39,8 @@
4040 * (bug 34723) When editing a script page on a RTL wiki the textbox should be LTR.
4141 * (bug 34762) Calling close() on a DatabaseBase object now clears the connection.
4242 * (bug 34863) Show deletion log extract on non-existent file pages if applicable.
 43+* (bug 28019) Let ?preloadtitle=foo be passed on to target of
 44+ Special:MyPage and Special:MyTalk
4345
4446 === API changes in 1.20 ===
4547 * (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.

Status & tagging log