r112942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112941‎ | r112942 | r112943 >
Date:12:00, 3 March 2012
Author:aaron
Status:reverted
Tags:gerritmigration 
Comment:
[FlaggedRevs]
* Call setRelevantTitle() in Special:Stabilization to improve UI context
* Fixed more deprecation notices
Modified paths:
  • /trunk/extensions/FlaggedRevs/frontend/FlaggedRevsLogView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/frontend/RejectConfirmationFormUI.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/frontend/specialpages/actions/Stabilization_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/frontend/specialpages/actions/Stabilization_body.php
@@ -36,7 +36,8 @@
3737 $out->showErrorPage( 'notargettitle', 'notargettext' );
3838 return;
3939 }
40 -
 40+ $this->getSkin()->setRelevantTitle( $title );
 41+
4142 $this->form = new PageStabilityGeneralForm( $user );
4243 $form = $this->form; // convenience
4344
Index: trunk/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php
@@ -41,7 +41,7 @@
4242 }
4343
4444 # Create a LogPager item to get the results and a LogEventsList item to format them...
45 - $loglist = new LogEventsList( $this->getUser()->getSkin(), $out, 0 );
 45+ $loglist = new LogEventsList( $this->getContext()->getSkin(), $out, 0 );
4646 $pager = new LogPager( $loglist, 'review', $this->user, '', '', $conds );
4747
4848 # Explanatory text
Index: trunk/extensions/FlaggedRevs/frontend/FlaggedRevsLogView.php
@@ -34,9 +34,8 @@
3535 * @return string
3636 */
3737 public static function stabilityLogLinks( $title, $timestamp, $params ) {
38 - global $wgUser;
3938 # Add history link showing edits right before the config change
40 - $hist = $wgUser->getSkin()->link(
 39+ $hist = Linker::link(
4140 $title,
4241 wfMsgHtml( 'hist' ),
4342 array(),
@@ -97,7 +96,7 @@
9897 * Create revision, diff, and history links for log line entry
9998 */
10099 public static function reviewLogLinks( $action, $title, $params ) {
101 - global $wgUser, $wgLang;
 100+ global $wgLang;
102101 $links = '';
103102 # Show link to page with oldid=x as well as the diff to the former stable rev.
104103 # Param format is <rev id, last stable id, rev timestamp>.
@@ -110,7 +109,7 @@
111110 ? 'review-logentry-diff2' // unreviewed
112111 : 'review-logentry-diff'; // reviewed
113112 $links .= '(';
114 - $links .= $wgUser->getSkin()->linkKnown(
 113+ $links .= Linker::linkKnown(
115114 $title,
116115 wfMsgHtml( $msg ),
117116 array(),
@@ -124,7 +123,7 @@
125124 : $params[2];
126125 $time = $wgLang->timeanddate( $ts, true );
127126 $links .= ' (';
128 - $links .= $wgUser->getSkin()->linkKnown(
 127+ $links .= Linker::linkKnown(
129128 $title,
130129 wfMsgHtml( 'review-logentry-id', $revId, $time ),
131130 array(),
Index: trunk/extensions/FlaggedRevs/frontend/RejectConfirmationFormUI.php
@@ -130,7 +130,6 @@
131131
132132 $form .= '</div>';
133133
134 - $skin = $this->form->getUser()->getSkin();
135134 $reviewTitle = SpecialPage::getTitleFor( 'RevisionReview' );
136135 $form .= Xml::openElement( 'form',
137136 array( 'method' => 'POST', 'action' => $reviewTitle->getFullUrl() ) );
@@ -146,7 +145,7 @@
147146 'wpReason', 120, $defaultSummary, array( 'maxlength' => 200 ) ) . "<br />";
148147 $form .= Html::input( 'wpSubmit', wfMsg( 'revreview-reject-confirm' ), 'submit' );
149148 $form .= ' ';
150 - $form .= $skin->link( $this->form->getPage(), wfMsg( 'revreview-reject-cancel' ),
 149+ $form .= Linker::link( $this->form->getPage(), wfMsg( 'revreview-reject-cancel' ),
151150 array( 'onClick' => 'history.back(); return history.length <= 1;' ),
152151 array( 'oldid' => $this->form->getRefId(), 'diff' => $this->form->getOldId() ) );
153152 $form .= Xml::closeElement( 'form' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114402Revert r112773, r112941, r112942, r113389: unreviewed revisions in FlaggedRevs....catrope20:30, 21 March 2012

Status & tagging log