r112927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112926‎ | r112927 | r112928 >
Date:23:12, 2 March 2012
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed tests that were broken by r112150.
Modified paths:
  • /trunk/extensions/VisualEditor/tests/ve/ve.dm.DocumentNode.test.js (modified) (history)
  • /trunk/extensions/VisualEditor/tests/ve/ve.dm.TransactionProcessor.test.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/tests/ve/ve.dm.DocumentNode.test.js
@@ -218,9 +218,9 @@
219219
220220 // Test 1
221221 deepEqual(
222 - documentModel.prepareElementAttributeChange( 0, 'set', 'test', 1234 ).getOperations(),
 222+ documentModel.prepareElementAttributeChange( 0, 'test', 1234 ).getOperations(),
223223 [
224 - { 'type': 'attribute', 'method': 'set', 'key': 'test', 'value': 1234 },
 224+ { 'type': 'attribute', 'key': 'test', 'from': undefined, 'to': 1234 },
225225 { 'type': 'retain', 'length': 34 }
226226 ],
227227 'prepareElementAttributeChange retains data after attribute change for first element'
@@ -228,10 +228,10 @@
229229
230230 // Test 2
231231 deepEqual(
232 - documentModel.prepareElementAttributeChange( 5, 'set', 'test', 1234 ).getOperations(),
 232+ documentModel.prepareElementAttributeChange( 5, 'test', 1234 ).getOperations(),
233233 [
234234 { 'type': 'retain', 'length': 5 },
235 - { 'type': 'attribute', 'method': 'set', 'key': 'test', 'value': 1234 },
 235+ { 'type': 'attribute', 'key': 'test', 'from': undefined, 'to': 1234 },
236236 { 'type': 'retain', 'length': 29 }
237237 ],
238238 'prepareElementAttributeChange retains data before and after attribute change'
Index: trunk/extensions/VisualEditor/tests/ve/ve.dm.TransactionProcessor.test.js
@@ -8,7 +8,7 @@
99 // We should be creating transactions directly and feeding those into
1010 // commit()/rollback() --Roan
1111 var elementAttributeChange = documentModel.prepareElementAttributeChange(
12 - 0, 'set', 'test', 1
 12+ 0, 'test', 1
1313 );
1414
1515 // Test 1

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112150Replaced "set" and "clear" method for attribute transactions with "replace" m...tparscal21:23, 22 February 2012

Status & tagging log