r112911 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112910‎ | r112911 | r112912 >
Date:19:35, 2 March 2012
Author:ialex
Status:ok
Tags:
Comment:
Per happy-melon, fix for r107653: don't add the error class on success message
Modified paths:
  • /branches/REL1_19/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -837,7 +837,8 @@
838838 $undoMsg = 'norev';
839839 }
840840
841 - $this->editFormPageTop .= $wgOut->parse( "<div class=\"error mw-undo-{$undoMsg}\">" .
 841+ $class = ( $undoMsg == 'success' ? '' : 'error ' ) . "mw-undo-{$undoMsg}";
 842+ $this->editFormPageTop .= $wgOut->parse( "<div class=\"{$class}\">" .
842843 wfMsgNoTrans( 'undo-' . $undoMsg ) . '</div>', true, /* interface */true );
843844 }
844845
Index: branches/REL1_19/phase3/includes/EditPage.php
@@ -828,7 +828,8 @@
829829 $undoMsg = 'norev';
830830 }
831831
832 - $this->editFormPageTop .= $wgOut->parse( "<div class=\"error mw-undo-{$undoMsg}\">" .
 832+ $class = ( $undoMsg == 'success' ? '' : 'error ' ) . "mw-undo-{$undoMsg}";
 833+ $this->editFormPageTop .= $wgOut->parse( "<div class=\"{$class}\">" .
833834 wfMsgNoTrans( 'undo-' . $undoMsg ) . '</div>', true, /* interface */true );
834835 }
835836

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107653* Inverted the precedence between section edition and revision undoing, now u...ialex20:43, 30 December 2011

Status & tagging log