r112867 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112866‎ | r112867 | r112868 >
Date:01:35, 2 March 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/lockmanager/LockManager.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/filerepo/backend/lockmanager/LockManager.php
@@ -56,7 +56,10 @@
5757 * @return Status
5858 */
5959 final public function lock( array $paths, $type = self::LOCK_EX ) {
60 - return $this->doLock( array_unique( $paths ), $this->lockTypeMap[$type] );
 60+ wfProfileIn( __METHOD__ );
 61+ $status = $this->doLock( array_unique( $paths ), $this->lockTypeMap[$type] );
 62+ wfProfileOut( __METHOD__ );
 63+ return $status;
6164 }
6265
6366 /**
@@ -67,7 +70,10 @@
6871 * @return Status
6972 */
7073 final public function unlock( array $paths, $type = self::LOCK_EX ) {
71 - return $this->doUnlock( array_unique( $paths ), $this->lockTypeMap[$type] );
 74+ wfProfileIn( __METHOD__ );
 75+ $status = $this->doUnlock( array_unique( $paths ), $this->lockTypeMap[$type] );
 76+ wfProfileOut( __METHOD__ );
 77+ return $status;
7278 }
7379
7480 /**
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
7581 Merged /trunk/phase3/includes:r112866
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
7682 Merged /trunk/phase3:r112866

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112866Added some lock call profilingaaron01:34, 2 March 2012

Status & tagging log