r112841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112840‎ | r112841 | r112842 >
Date:22:03, 1 March 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/FileOp.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/SwiftFileBackend.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/filerepo/backend/SwiftFileBackend.php
@@ -792,7 +792,7 @@
793793 */
794794 protected function logException( Exception $e, $func, array $params ) {
795795 wfDebugLog( 'SwiftBackend',
796 - get_class( $e ) . " in '{$func}' (given '" . serialize( $params ) . "')" .
 796+ get_class( $e ) . " in '{$func}' (given '" . FormatJson::encode( $params ) . "')" .
797797 ( $e instanceof InvalidResponseException
798798 ? ": {$e->getMessage()}"
799799 : ""
Index: branches/wmf/1.19wmf1/includes/filerepo/backend/FileOp.php
@@ -346,7 +346,7 @@
347347 $params['failedAction'] = $action;
348348 try {
349349 wfDebugLog( 'FileOperation',
350 - get_class( $this ) . ' failed:' . serialize( $params ) );
 350+ get_class( $this ) . ' failed:' . FormatJson::encode( $params ) );
351351 } catch ( Exception $e ) {
352352 // bad config? debug log error?
353353 }
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
354354 Merged /trunk/phase3/includes:r112839-112840
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
355355 Merged /trunk/phase3:r112839-112840

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112839Error log readability is niceaaron21:59, 1 March 2012
r112840r112839: missing file changeaaron22:01, 1 March 2012

Status & tagging log