r112814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112813‎ | r112814 | r112815 >
Date:15:28, 1 March 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Reverted the reversion of r112787 in rr112812 and add the missing continue
Modified paths:
  • /trunk/extensions/Translate/scripts/export.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/export.php
@@ -109,12 +109,17 @@
110110
111111 foreach ( $groups as $groupId => $group ) {
112112 if ( !$group instanceof MessageGroup ) {
113 - STDERR( "Invalid group: " . $groupId );
 113+ STDERR( "Unknown message group $groupId" );
114114 exit( 1 );
115115 }
116116
117 - STDERR( 'Exporting ' . $groupId );
 117+ if ( $group->isMeta() ) {
 118+ STDERR( "Skipping meta message group $groupId" );
 119+ continue;
 120+ }
118121
 122+ STDERR( "Exporting $groupId" );
 123+
119124 $langs = $reqLangs;
120125 if ( $threshold ) {
121126 $stats = MessageGroupStats::forGroup( $groupId );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112787Followup r111456. Move the complexity to caller and keep other code "clean".nikerabbit10:33, 1 March 2012
r112812Revert r112787: Broke exports....siebrand15:20, 1 March 2012

Status & tagging log