r112809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112808‎ | r112809 | r112810 >
Date:13:57, 1 March 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
change random and home buttons to links

there is no reason these should rely on javascript
this makes the site more accessible to those without js
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/templates/SearchTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -665,11 +665,13 @@
666666 display: inline-block;
667667 }
668668
 669+#nav .button,
669670 #nav button {
670671 background: url(images/buttonbg.gif) no-repeat center;
671672 border: 0;
672 - height: 23px;
673 - width: 83px;
 673+ padding: 8px;
 674+ color: black;
 675+ display: inline-block;
674676 }
675677
676678 #disableButtons {
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -653,11 +653,13 @@
654654 display: inline-block;
655655 }
656656
 657+#nav .button,
657658 #nav button {
658659 background: url(images/buttonbg.gif) no-repeat center;
659660 border: 0;
660 - height: 23px;
661 - width: 83px;
 661+ padding: 8px;
 662+ color: black;
 663+ display: inline-block;
662664 }
663665
664666 #disableButtons {
Index: trunk/extensions/MobileFrontend/templates/SearchTemplate.php
@@ -42,8 +42,8 @@
4343 </div>
4444 <div class='nav' id='nav' {$logoDisplayNone}>
4545 {$languageSelectionDiv}
46 - <button onclick="javascript:location.href='{$mainPageUrl}';" type="submit" id="homeButton">{$homeButton}</button>
47 - <button onclick="javascript:location.href='{$randomPageUrl}';" type="submit" id="randomButton">{$randomButton}</button>
 46+ <a href="{$mainPageUrl}" id="homeButton" class="button">{$homeButton}</a>
 47+ <a href="{$randomPageUrl}" id="randomButton" class="button">{$randomButton}</a>
4848 </div>
4949 </div>
5050 HTML;

Status & tagging log