r112791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112790‎ | r112791 | r112792 >
Date:11:04, 1 March 2012
Author:jdlrobson
Status:ok
Tags:
Comment:
don't define width of search results in javascript

left and right positioning will do just fine here
this takes care of bug 32175
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/opensearch.js
@@ -98,7 +98,6 @@
9999 results.style.display = 'block';
100100 var top = sq.offsetParent.offsetTop + sq.offsetHeight + sq.offsetTop + 1;
101101 results.style.top = top + 'px';
102 - results.style.width = sq.offsetWidth - 2 + 'px'; // -2px border left and right
103102
104103 if ( !sections || sections.length < 1 ) {
105104 results.innerHTML = "No results";
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -181,6 +181,7 @@
182182 z-index: 2;
183183 position: absolute;
184184 left: 53px;
 185+ right: 41px;
185186 }
186187
187188 html[dir="rtl"] #results {

Status & tagging log