r112788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112787‎ | r112788 | r112789 >
Date:10:42, 1 March 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Restore many missing spaces from r112589
Also fixed indentation by spaces
And please don't ever use != ''. It's misleading.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/actions/HistoryAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/HistoryAction.php
@@ -619,7 +619,7 @@
620620 }
621621
622622 if ( $tools ) {
623 - $s .= $this->msg( 'parentheses' )->rawParams( $lang->pipeList( $tools ) )->escaped();
 623+ $s .= ' '. $this->msg( 'parentheses' )->rawParams( $lang->pipeList( $tools ) )->escaped();
624624 }
625625
626626 # Tags
Index: trunk/phase3/includes/ChangesList.php
@@ -894,7 +894,7 @@
895895 }
896896 # Total change link
897897 $r .= ' ';
898 - $logtext = '';
 898+ $logtext = '';
899899 if( !$allLogs ) {
900900 if( !ChangesList::userCan( $rcObj, Revision::DELETED_TEXT, $this->getUser() ) ) {
901901 $logtext .= $nchanges[$n];
@@ -933,7 +933,7 @@
934934 );
935935 }
936936
937 - if( $logtext != '' ) {
 937+ if( $logtext !== '' ) {
938938 $r .= $this->msg( 'parentheses' )->rawParams( $logtext )->escaped();
939939 }
940940
@@ -1008,7 +1008,7 @@
10091009 $r .= $link . '</span>';
10101010
10111011 if ( !$type == RC_LOG || $type == RC_NEW ) {
1012 - $r .= $this->msg( 'parentheses' )->rawParams( $rcObj->curlink . $this->message['pipe-separator'] . $rcObj->lastlink )->escaped();
 1012+ $r .= ' ' . $this->msg( 'parentheses' )->rawParams( $rcObj->curlink . $this->message['pipe-separator'] . $rcObj->lastlink )->escaped();
10131013 }
10141014 $r .= ' . . ';
10151015
@@ -1134,7 +1134,7 @@
11351135 # Diff and hist links
11361136 if ( $type != RC_LOG ) {
11371137 $query['action'] = 'history';
1138 - $r .= $this->msg( 'parentheses' )->rawParams( $rcObj->difflink . $this->message['pipe-separator'] . Linker::linkKnown(
 1138+ $r .= ' ' . $this->msg( 'parentheses' )->rawParams( $rcObj->difflink . $this->message['pipe-separator'] . Linker::linkKnown(
11391139 $rcObj->getTitle(),
11401140 $this->message['hist'],
11411141 array(),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112589(bug 34702) More localised parentheses. Patch contributed by Yusuke Matsubara.siebrand11:56, 28 February 2012

Status & tagging log