r112767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112766‎ | r112767 | r112768 >
Date:03:11, 1 March 2012
Author:johnduhart
Status:ok
Tags:
Comment:
Removed unused parameters
Modified paths:
  • /trunk/extensions/ArticleCreationWorkflow/SpecialArticleCreationLanding.php (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/includes/ArticleCreationUtil.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleCreationWorkflow/includes/ArticleCreationUtil.php
@@ -81,11 +81,10 @@
8282
8383 /**
8484 * Track the page stats to the special article creation landing page
85 - * @param $request Object
86 - * @param $user Object
 85+ *
8786 * @param $par string - the title for the non-existing article
8887 */
89 - public static function TrackSpecialLandingPage( $request, $user, $par ) {
 88+ public static function TrackSpecialLandingPage( $par ) {
9089
9190 $event = self::trackingBucket() . '-impression';
9291
Index: trunk/extensions/ArticleCreationWorkflow/SpecialArticleCreationLanding.php
@@ -15,8 +15,6 @@
1616 }
1717
1818 public function execute( $par ) {
19 - global $wgUser, $wgRequest;
20 -
2119 $out = $this->getOutput();
2220 $title = Title::newFromText( $par );
2321
@@ -37,7 +35,7 @@
3836 $out->addModules( 'ext.articleCreation.user' );
3937 $out->addHtml( ArticleCreationTemplates::getLandingPage($par) );
4038
41 - ArticleCreationUtil::TrackSpecialLandingPage( $wgRequest, $wgUser, $par );
 39+ ArticleCreationUtil::TrackSpecialLandingPage( $par );
4240 }
4341
4442 }

Status & tagging log