r112743 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112742‎ | r112743 | r112744 >
Date:23:41, 29 February 2012
Author:catrope
Status:ok
Tags:
Comment:
1.19wmf1: Add (array) casts in ArticleFeedbackv5 to shut up notices. Will also add in trunk
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5Utils.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5Utils.php
@@ -177,7 +177,7 @@
178178
179179 $dbw->begin();
180180
181 - foreach ( $filters as $filter ) {
 181+ foreach ( (array)$filters as $filter ) {
182182 $rows[] = array(
183183 'afc_page_id' => $pageId,
184184 'afc_filter_name' => $filter,
@@ -196,7 +196,7 @@
197197
198198 $value = $decrement ? 'afc_filter_count - 1' : 'afc_filter_count + 1';
199199
200 - foreach ( $filters as $filter ) {
 200+ foreach ( (array)$filters as $filter ) {
201201 # Update each row with the new count.
202202 $dbw->update(
203203 'aft_article_filter_count',

Status & tagging log