r112720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112719‎ | r112720 | r112721 >
Date:20:50, 29 February 2012
Author:hashar
Status:ok
Tags:
Comment:
revert r112702 bad commit

Somehow r112702 is playing fun with svn history
Modified paths:
  • /trunk/extensions/ApiSandbox/ext.apiSandbox.css (replaced) (history)
  • /trunk/extensions/ApiSandbox/ext.apiSandbox.js (replaced) (history)

Diff [purge]

Index: trunk/extensions/ApiSandbox/ext.apiSandbox.js
@@ -516,10 +516,6 @@
517517 .appendTo( '#api-sandbox-parameters' )
518518 .add( $submit )
519519 .click( function ( e ) {
520 - // Don't do default action (crawl up to <form> and trigger a submit).
521 - // That would submit it twice (bug 34790)
522 - e.preventDefault();
523 -
524520 $form.submit();
525521 } )
526522 .button({ disabled: true });
@@ -606,9 +602,6 @@
607603 $form.submit( function ( e ) {
608604 var url, params, mustBePosted;
609605
610 - // Prevent browser from submitting the form
611 - // and reloading the page to the action-url.
612 - // We're doing it with AJAX instead, below.
613606 e.preventDefault();
614607
615608 if ( $submit.button( 'option', 'disabled' ) === true ) {
@@ -630,7 +623,6 @@
631624 }
632625
633626 showLoading( $output );
634 -
635627 if ( mustBePosted ) {
636628 $requestUrl.val( url );
637629 if ( params.length > 0 ) {
Property changes on: trunk/extensions/ApiSandbox/ext.apiSandbox.js
___________________________________________________________________
Added: svn:eol-style
638630 + native
Property changes on: trunk/extensions/ApiSandbox/ext.apiSandbox.css
___________________________________________________________________
Added: svn:eol-style
639631 + native

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112702[ApiSandbox] Prevent duplicate submission of the form when clicking "Make Req...krinkle18:03, 29 February 2012

Status & tagging log