r112715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112714‎ | r112715 | r112716 >
Date:20:22, 29 February 2012
Author:foxtrott
Status:deferred
Tags:
Comment:
change classname
Modified paths:
  • /trunk/extensions/SemanticForms/SemanticForms.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormEditAction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/SemanticForms.php
@@ -80,8 +80,8 @@
8181
8282 $wgHooks['LinkEnd'][] = 'SFFormLinker::setBrokenLink';
8383 // 'SkinTemplateNavigation' replaced 'SkinTemplateTabs' in the Vector skin
84 -$wgHooks['SkinTemplateTabs'][] = 'FormeditAction::displayTab';
85 -$wgHooks['SkinTemplateNavigation'][] = 'FormeditAction::displayTab2';
 84+$wgHooks['SkinTemplateTabs'][] = 'SFFormEditAction::displayTab';
 85+$wgHooks['SkinTemplateNavigation'][] = 'SFFormEditAction::displayTab2';
8686 $wgHooks['smwInitProperties'][] = 'SFUtils::initProperties';
8787 $wgHooks['AdminLinks'][] = 'SFUtils::addToAdminLinks';
8888 $wgHooks['ArticlePurge'][] = 'SFFormUtils::purgeCache';
@@ -94,10 +94,10 @@
9595
9696 if ( version_compare( $wgVersion, '1.18', '<' ) ) {
9797 // TODO: Using UnknownAction is deprecated from MW 1.18 onwards.
98 - $wgHooks['UnknownAction'][] = 'FormeditAction::displayForm';
 98+ $wgHooks['UnknownAction'][] = 'SFFormEditAction::displayForm';
9999 } else {
100100 // Introduced in MW 1.18.
101 - $wgActions['formedit'] = true;
 101+ $wgActions['formedit'] = 'SFFormEditAction';
102102 }
103103
104104 $wgAPIModules['sfautocomplete'] = 'SFAutocompleteAPI';
@@ -150,7 +150,7 @@
151151 $wgAutoloadClasses['SFParserFunctions'] = $sfgIP . '/includes/SF_ParserFunctions.php';
152152 $wgAutoloadClasses['SFAutocompleteAPI'] = $sfgIP . '/includes/SF_AutocompleteAPI.php';
153153 $wgAutoloadClasses['SFAutoeditAPI'] = $sfgIP . '/includes/SF_AutoeditAPI.php';
154 -$wgAutoloadClasses['FormeditAction'] = $sfgIP . '/includes/SF_FormEditAction.php';
 154+$wgAutoloadClasses['SFFormEditAction'] = $sfgIP . '/includes/SF_FormEditAction.php';
155155
156156 // FormInputs
157157 $wgAutoloadClasses['SFFormInput'] = $sfgIP . '/includes/forminputs/SF_FormInput.php';
Index: trunk/extensions/SemanticForms/includes/SF_FormEditAction.php
@@ -1,7 +1,10 @@
22 <?php
3 -/*
4 - * To change this template, choose Tools | Templates
5 - * and open the template in the editor.
 3+/**
 4+ * Handles the formedit action.
 5+ *
 6+ * @author Stephan Gambke
 7+ * @file
 8+ * @ingroup SF
69 */
710
811 // TODO: Action class did not exist until MW 1.18
@@ -9,12 +12,7 @@
1013 class Action{}
1114 }
1215
13 -/**
14 - * Description of FormeditAction
15 - *
16 - * @author Stephan Gambke
17 - */
18 -class FormeditAction extends Action
 16+class SFFormEditAction extends Action
1917 {
2018 /**
2119 * Return the name of the action this object responds to