r112713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112712‎ | r112713 | r112714 >
Date:20:11, 29 February 2012
Author:ashley
Status:ok
Tags:
Comment:
PrivateDomains: fix "hook has invalid signature" bug by removing the ampersand here since AlternateEdit's only param is $this (EditPage object) + bump version number
Modified paths:
  • /trunk/extensions/PrivateDomains/PrivateDomains.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PrivateDomains/PrivateDomains.php
@@ -5,7 +5,7 @@
66 *
77 * @file
88 * @ingroup Extensions
9 - * @version 1.0
 9+ * @version 1.1
1010 * @author Inez Korczyński <korczynski@gmail.com>
1111 * @author Jack Phoenix <jack@countervandalism.net>
1212 * @link http://www.mediawiki.org/wiki/Extension:PrivateDomains Documentation
@@ -19,7 +19,7 @@
2020 // Extension credits that will show up on Special:Version
2121 $wgExtensionCredits['specialpage'][] = array(
2222 'name' => 'PrivateDomains',
23 - 'version' => '1.0',
 23+ 'version' => '1.1',
2424 'author' => array( 'Inez Korczyński', 'Jack Phoenix' ),
2525 'description' => 'Allows to restrict editing to users with a certain e-mail address',
2626 'url' => 'https://www.mediawiki.org/wiki/Extension:PrivateDomains',
@@ -77,7 +77,7 @@
7878 * If user isn't in group privatedomains/staff/bureaucrat then
7979 * deny access to edit page and show information box.
8080 */
81 -function pd_AlternateEdit( &$editpage ) {
 81+function pd_AlternateEdit( $editpage ) {
8282 global $wgUser;
8383 $groups = $wgUser->getEffectiveGroups();
8484 if (

Status & tagging log