r112659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112658‎ | r112659 | r112660 >
Date:23:48, 28 February 2012
Author:kaldari
Status:ok
Tags:acw-deploy 
Comment:
making sure colored buttons get white icons, implementing a smarter css selector scheme for large colored buttons (less redundancy)
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css
@@ -68,6 +68,15 @@
6969 body button.ui-button::-moz-focus-inner {
7070 border: 0;
7171 }
 72+/* Give large buttons some extra padding */
 73+body .ui-button-large {
 74+ padding: 5px;
 75+}
 76+/* Use white icons for colored buttons */
 77+.ui-button-green .ui-icon, .ui-button-blue .ui-icon, .ui-button-red .ui-icon, .ui-button-orange .ui-icon {
 78+ /* @embed */
 79+ background-image: url(images/ui-icons_ffffff_256x240.png) !important;
 80+}
7281
7382 /* Green buttons */
7483
@@ -82,18 +91,15 @@
8392 /* @embed */
8493 background: #339b65 url(images/button-green-hover.png) repeat-x scroll 50% 100% !important;
8594 }
86 -body .ui-button.ui-button-green-large {
87 - color: white !important;
88 - border-color: #97af7e !important;
 95+body .ui-button.ui-button-green.ui-button-large {
8996 /* @embed */
9097 background: #3cb677 url(images/button-green-large.png) repeat-x scroll 50% 100% !important;
9198 }
92 -body .ui-button.ui-button-green-large:hover {
93 - border-color: #778e61 !important;
 99+body .ui-button.ui-button-green.ui-button-large:hover {
94100 /* @embed */
95101 background: #339b65 url(images/button-green-hover-large.png) repeat-x scroll 50% 100% !important;
96102 }
97 -body .ui-button.ui-button-green.disabled, body .ui-button.ui-button-green-large.disabled {
 103+body .ui-button.ui-button-green.disabled {
98104 filter:alpha(opacity=50);
99105 -moz-opacity:0.50;
100106 -khtml-opacity: 0.50;
@@ -113,18 +119,15 @@
114120 /* @embed */
115121 background: #2b569e url(images/button-blue-hover.png) repeat-x scroll 50% 100% !important;
116122 }
117 -body .ui-button.ui-button-blue-large {
118 - color: white !important;
119 - border-color: #628acb !important;
 123+body .ui-button.ui-button-blue.ui-button-large {
120124 /* @embed */
121125 background: #3365ba url(images/button-blue-large.png) repeat-x scroll 50% 100% !important;
122126 }
123 -body .ui-button.ui-button-blue-large:hover {
124 - border-color: #5375ad !important;
 127+body .ui-button.ui-button-blue.ui-button-large:hover {
125128 /* @embed */
126129 background: #2b569e url(images/button-blue-hover-large.png) repeat-x scroll 50% 100% !important;
127130 }
128 -body .ui-button.ui-button-blue.disabled, body .ui-button.ui-button-blue-large.disabled {
 131+body .ui-button.ui-button-blue.disabled {
129132 filter:alpha(opacity=50);
130133 -moz-opacity:0.50;
131134 -khtml-opacity: 0.50;
@@ -144,18 +147,15 @@
145148 /* @embed */
146149 background: #ad0000 url(images/button-red-hover.png) repeat-x scroll 50% 100% !important;
147150 }
148 -body .ui-button.ui-button-red-large {
149 - color: white !important;
150 - border-color: #af977e !important;
 151+body .ui-button.ui-button-red.ui-button-large {
151152 /* @embed */
152153 background: #cb0000 url(images/button-red.png) repeat-x scroll 50% 100% !important;
153154 }
154 -body .ui-button.ui-button-red-large:hover {
155 - border-color: #8e7761 !important;
 155+body .ui-button.ui-button-red.ui-button-large:hover {
156156 /* @embed */
157157 background: #ad0000 url(images/button-red-hover.png) repeat-x scroll 50% 100% !important;
158158 }
159 -body .ui-button.ui-button-red.disabled, body .ui-button.ui-button-red-large.disabled {
 159+body .ui-button.ui-button-red.disabled {
160160 filter:alpha(opacity=50);
161161 -moz-opacity:0.50;
162162 -khtml-opacity: 0.50;
@@ -175,18 +175,15 @@
176176 /* @embed */
177177 background: #cc6c11 url(images/button-orange-hover.png) repeat-x scroll 50% 100% !important;
178178 }
179 -body .ui-button.ui-button-orange-large {
180 - color: white !important;
181 - border-color: #f3a863 !important;
 179+body .ui-button.ui-button-orange.ui-button-large {
182180 /* @embed */
183181 background: #f07f14 url(images/button-orange-large.png) repeat-x scroll 50% 100% !important;
184182 }
185 -body .ui-button.ui-button-orange-large:hover {
186 - border-color: #ce9055 !important;
 183+body .ui-button.ui-button-orange.ui-button-large:hover {
187184 /* @embed */
188185 background: #cc6c11 url(images/button-orange-hover-large.png) repeat-x scroll 50% 100% !important;
189186 }
190 -body .ui-button.ui-button-orange.disabled, body .ui-button.ui-button-orange-large.disabled {
 187+body .ui-button.ui-button-orange.disabled {
191188 filter:alpha(opacity=50);
192189 -moz-opacity:0.50;
193190 -khtml-opacity: 0.50;

Status & tagging log