r112640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112639‎ | r112640 | r112641 >
Date:21:10, 28 February 2012
Author:foxtrott
Status:deferred
Tags:
Comment:
bugfix (SF produces broken html)
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -373,10 +373,7 @@
374374 $text .= self::printAltFormsList( $alt_forms, $target_name );
375375 $text .= "</div>\n";
376376 }
377 - $text .= <<<END
378 - <form name="createbox" id="sfForm" action="" method="post" class="createbox">
379 -
380 -END;
 377+ $text .= '<form name="createbox" id="sfForm" method="post" class="createbox">';
381378 $pre_form_html = '';
382379 wfRunHooks( 'sfHTMLBeforeForm', array( &$target_title, &$pre_form_html ) );
383380 $text .= $pre_form_html;
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php
@@ -99,6 +99,7 @@
100100 $textarea_attrs['cols'] = 90;
101101 $textarea_attrs['style'] = 'width: auto';
102102 } else {
 103+ $textarea_attrs['cols'] = 90;
103104 $textarea_attrs['style'] = 'width: 100%';
104105 }
105106
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php
@@ -110,6 +110,7 @@
111111 $textarea_attrs['cols'] = 90;
112112 $textarea_attrs['style'] = 'width: auto';
113113 } else {
 114+ $textarea_attrs['cols'] = 90;
114115 $textarea_attrs['style'] = 'width: 100%';
115116 }
116117