r112634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112633‎ | r112634 | r112635 >
Date:20:46, 28 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1/extensions (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php
@@ -555,6 +555,9 @@
556556 }
557557 $collection = CollectionSession::getCollection();
558558 $revision = Revision::newFromTitle( $title, $oldid );
 559+ if ( !$revision ) {
 560+ return false;
 561+ }
559562
560563 $item = array(
561564 'type' => 'article',
Index: branches/wmf/1.19wmf1/extensions/CentralAuth/specials/SpecialCentralAuth.php
@@ -381,7 +381,7 @@
382382 $this->foreignUserLink( $row['wiki'] ) .
383383 "</td><td colspan='4'>{$notMerged}</td></tr>\n";
384384 }
385 - return implode( '\n', $rows );
 385+ return implode( "\n", $rows );
386386 }
387387
388388 /**
Property changes on: branches/wmf/1.19wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
389389 Merged /trunk/extensions:r112571,112628

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112571Fixed:...aaron02:57, 28 February 2012
r112628(Bug 34776) Unattached accounts add literal \n on Special:CentralAuth...platonides19:14, 28 February 2012

Status & tagging log