r112595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112594‎ | r112595 | r112596 >
Date:14:11, 28 February 2012
Author:gwicke
Status:deferred
Tags:
Comment:
Tweak martian regexp and grepper output format.
Modified paths:
  • /trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/martian-endtags.sh (modified) (history)
  • /trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/tests/parser/dumpGrepPatterns/martian-endtags.sh
@@ -14,7 +14,7 @@
1515
1616 #regexp="<(?!\/|$exts|$htmls)[^>]*>.*?<!--([^<]+|<(\/|$exts|$htmls)[^>]*>)*<\/(?!$exts|$htmls)[^>]*>"
1717 #regexp="&lt;(?!/|$normaltags)[^&]+&gt;[^&]+&lt;!--[^&-]*&lt;/(?!$normaltags)((?!&gt;).)+&gt;"
18 -regexp="</(?=[a-z])(?!$normaltags)[^&]+>"
 18+regexp="</(?=[a-z])(?!$normaltags)[^>]+>"
1919 #regexp="<(?!\/|$exts|$htmls)[^>]*>"
2020
2121 #echo $regexp
Index: trunk/extensions/VisualEditor/tests/parser/dumpGrepper.js
@@ -47,8 +47,8 @@
4848
4949 reader.on( 'revision', grepper.grepRev.bind( grepper ) );
5050 grepper.on( 'match', function ( revision, bits ) {
51 - console.log( 'Match:' + revision.page.title );
5251 for ( var i = 0, l = bits.length; i < l-1; i += 2 ) {
 52+ console.log( '== Match: [[' + revision.page.title + ']] ==' );
5353 var m = bits[i+1];
5454 if ( argv.color ) {
5555 console.log( bits[i].substr(-40) + m.green + bits[i+2].substr( 0, 40 ) );

Status & tagging log